-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(client/android): Add report button for connection failures with webhook integration #2484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…erverAdded function + Add keyHasWebhook function
…rButtonHandler in showToast function + Add button to html template
Thank you for your contribution. Snackbars should have only one action (with an optional dismiss): https://m3.material.io/components/snackbar/guidelines#ae0935b0-a14e-4dec-8c3c-2c0809acffeb. This needs a redesign. |
@techamateur, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution 👍. Before we review the code, please clean up the translation files, as they are handled automatically by our pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the translation changes, they are handled by a pipeline. The only thing you need to change is resources/original_messages.json
.
In addition, it will also simplifies the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, it's 'resources/original_messages.json`, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, updated. en.json
is for local debug.
Resolves #2036
What
REPORT
button next toDETAILS
in connection error dialog.Why
How to Test
ss://...?&webhook=https://example.com/report#key
).REPORT
and verify webhook receives JSON payload:Screenshot
