Skip to content

refactor(client): use client when creating a new tunnel #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

refactor(client): use client when creating a new tunnel #2498

merged 3 commits into from
May 19, 2025

Conversation

emohandesi
Copy link
Contributor

This refactoring was requested in #2369.

@emohandesi emohandesi requested review from a team as code owners May 16, 2025 04:32
62w71st
62w71st reviewed May 16, 2025
View reviewed changes
62w71st
62w71st reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@62w71st 62w71st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the PR?

jyyi1
jyyi1 reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. The overall logic looks good, just a few minor suggestions.

I'll also trigger the CI pipeline to see whether there are any build issues.

@emohandesi
Copy link
Contributor Author

Have you tested the PR?

Yes, I have built it and verified that the Outline app connects to VPN successfully on my Android phone.

fortuna
fortuna approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@fortuna fortuna enabled auto-merge (squash) May 19, 2025 16:35
jyyi1
jyyi1 approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jyyi1 jyyi1 mentioned this pull request May 19, 2025
Merged
@jyyi1 jyyi1 disabled auto-merge May 19, 2025 21:56
@jyyi1 jyyi1 enabled auto-merge (squash) May 19, 2025 21:58
@jyyi1 jyyi1 merged commit 46d55e5 into Jigsaw-Code:master May 19, 2025
25 checks passed
@fortuna fortuna mentioned this pull request May 23, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@62w71st 62w71st 62w71st left review comments

@fortuna fortuna fortuna approved these changes

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emohandesi @fortuna @62w71st @jyyi1