Skip to content

Support views involving vectors of blocks, Fixes #184 and #358 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

dlfivefifty
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (4d386cf) to head (ac75028).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   93.55%   93.59%   +0.04%     
==========================================
  Files          18       18              
  Lines        1644     1656      +12     
==========================================
+ Hits         1538     1550      +12     
  Misses        106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Collaborator

Looks like this closes #184? Thanks by the way, this will be really useful. Curious to hear your thoughts on #358, which is related.

@dlfivefifty dlfivefifty changed the title Support views involving vectors of blocks Support views involving vectors of blocks, Fixes #184 and #358 Feb 6, 2025
@dlfivefifty
Copy link
Member Author

OK I added a fix for #358 as well

@mtfishman
Copy link
Collaborator

OK I added a fix for #358 as well

Amazing, thanks!

@dlfivefifty dlfivefifty merged commit a4e544e into master Feb 6, 2025
16 checks passed
@dlfivefifty dlfivefifty deleted the dl/viewsofblockvector branch February 6, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants