Skip to content

Bump ImplicitDifferentiation bound + run CompatHelper on subpackages #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Apr 11, 2025

I just realized your ControlSystemsBase was stuck on an old version of ImplicitDifferentiation (0.4 when we're at 0.7), so I checked and your CompatHelper workflow doesn't see subdirectories. This PR should fix it, and CompatHelper should open new PRs itself soon to upgrade ImplicitDifferentiation

See also:

@baggepinnen
Copy link
Member

Thanks for the PR! It seems the extension needs an update to be compatible with the latest version of DI. Do you recognize this error https://github.com/JuliaControl/ControlSystems.jl/actions/runs/14397751088/job/40385323705?pr=980#step:5:61 ? It seems some internal function has gotten a different type signature?

@gdalle
Copy link
Contributor Author

gdalle commented Apr 14, 2025

Oh, that's probably because the new version of ImplicitDifferentiation only accepts vectors instead of general arrays. It's easier to code that way, but if it causes real problems downstream I may reconsider it

@baggepinnen
Copy link
Member

What's the intended workflow for handling matrices? vec -> reshape?

@gdalle
Copy link
Contributor Author

gdalle commented Apr 15, 2025

What's the intended workflow for handling matrices? vec -> reshape?

Yeah exactly, either I do it myself in ImplicitDifferentiation or every user does it. Inside ID it's easier to work with vectors because we need to solve a linear system, which is more naturally formulated with matrices. But you're not the first user for whom this is a problem, so I'll see what I can do

@gdalle
Copy link
Contributor Author

gdalle commented Apr 15, 2025

JuliaDecisionFocusedLearning/ImplicitDifferentiation.jl#167

@gdalle
Copy link
Contributor Author

gdalle commented Apr 15, 2025

@baggepinnen could you please approve the workflows? The last commit picks the version of ImplicitDifferentiation where arrays are supported again

@gdalle
Copy link
Contributor Author

gdalle commented Apr 15, 2025

Oh right, I see what's happening here. Your first ImplicitFunction did work with a byproduct z so I didn't bother to check the rest, but not all of them do actually. In the new version of ImplicitDifferentiation, byproducts are mandatory. Fixing it right now.
EDIT: actually, the problem was that hinfnorm returned a scalar instead of an array.

@gdalle gdalle changed the title Run CompatHelper on subpackages Bump ImplicitDifferentiation bound + run CompatHelper on subpackages Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (5ab74cf) to head (96e6a4d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage   92.41%   92.42%   +0.01%     
==========================================
  Files          41       41              
  Lines        4981     4990       +9     
==========================================
+ Hits         4603     4612       +9     
  Misses        378      378              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle
Copy link
Contributor Author

gdalle commented Apr 15, 2025

All good now I think

@baggepinnen baggepinnen merged commit 227f703 into JuliaControl:master Apr 15, 2025
5 checks passed
@baggepinnen
Copy link
Member

Thanks for all your fixes :)

@gdalle
Copy link
Contributor Author

gdalle commented Apr 15, 2025

Turns out the ImplicitDifferentiation ones were not needed after all😅 but it was a good excuse.
As a side note, since you're mostly working with scalars, this code would probably benefit tremendously from StaticArrays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants