-
Notifications
You must be signed in to change notification settings - Fork 90
Bump ImplicitDifferentiation bound + run CompatHelper on subpackages #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! It seems the extension needs an update to be compatible with the latest version of DI. Do you recognize this error https://github.com/JuliaControl/ControlSystems.jl/actions/runs/14397751088/job/40385323705?pr=980#step:5:61 ? It seems some internal function has gotten a different type signature? |
Oh, that's probably because the new version of ImplicitDifferentiation only accepts vectors instead of general arrays. It's easier to code that way, but if it causes real problems downstream I may reconsider it |
What's the intended workflow for handling matrices? |
Yeah exactly, either I do it myself in ImplicitDifferentiation or every user does it. Inside ID it's easier to work with vectors because we need to solve a linear system, which is more naturally formulated with matrices. But you're not the first user for whom this is a problem, so I'll see what I can do |
@baggepinnen could you please approve the workflows? The last commit picks the version of ImplicitDifferentiation where arrays are supported again |
Oh right, I see what's happening here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #980 +/- ##
==========================================
+ Coverage 92.41% 92.42% +0.01%
==========================================
Files 41 41
Lines 4981 4990 +9
==========================================
+ Hits 4603 4612 +9
Misses 378 378 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All good now I think |
Thanks for all your fixes :) |
Turns out the ImplicitDifferentiation ones were not needed after all😅 but it was a good excuse. |
I just realized your ControlSystemsBase was stuck on an old version of ImplicitDifferentiation (0.4 when we're at 0.7), so I checked and your CompatHelper workflow doesn't see subdirectories. This PR should fix it, and CompatHelper should open new PRs itself soon to upgrade ImplicitDifferentiation
See also: