Skip to content

debug: do not call jacobian! if nd==0 in linearize #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Conversation

franckgaga
Copy link
Member

@franckgaga franckgaga commented Apr 8, 2025

some backend works with empty matrices (e.g. AutoForwardDiff) others not (e.g. : AutoFiniteDiff)

closes #185

some backend works with empty matrices (e.g. `AutoForwardDiff`) others not (e.g. : `AutoFiniteDiff`)
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (3705821) to head (a006525).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          25       25           
  Lines        4204     4205    +1     
=======================================
+ Hits         4157     4158    +1     
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga
Copy link
Member Author

It fails on v.1.12 beta. I think there is a incompatibility with ControlSystemsBase. Will merge anyway and look at that later.

@franckgaga franckgaga closed this Apr 8, 2025
@franckgaga franckgaga reopened this Apr 8, 2025
@franckgaga franckgaga merged commit a8b8c9b into main Apr 8, 2025
7 of 9 checks passed
@franckgaga franckgaga deleted the debug_linearize branch April 8, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linearize is failing when using AutoFiniteDiff()
2 participants