Skip to content

Polygon(::AbstractVector) method not working on v0.5 for non base Vector types #236

Closed
@favba

Description

@favba

In v0.5 :

julia> using GeometryBasics, StaticArrays

julia> p = SA[Point(1.,1.), Point(2.,2.), Point(0.2,2.)]
3-element SVector{3, Point{2, Float64}} with indices SOneTo(3):
 [1.0, 1.0]
 [2.0, 2.0]
 [0.2, 2.0]

julia> Polygon(p)
ERROR: MethodError: no method matching Polygon(::SVector{3, Point{2, Float64}}, ::Vector{Vector{Point{2, Float64}}})
The type `Polygon` exists, but no method is defined for this combination of argument types when trying to construct it.

Closest candidates are:
  Polygon(::Array{Point{Dim, T}, 1}, ::Array{Array{Point{Dim, T}, 1}, 1}) where {Dim, T<:Real}
   @ GeometryBasics ~/.julia/packages/GeometryBasics/ebuW5/src/basic_types.jl:279
  Polygon(::AbstractArray{Point{Dim, T}, 1}, ::AbstractArray{AbstractArray{Point{Dim, T}, 1}, 1}) where {Dim, T}
   @ GeometryBasics ~/.julia/packages/GeometryBasics/ebuW5/src/basic_types.jl:289
  Polygon(::AbstractArray{Point{N, T}, 1}) where {N, T}
   @ GeometryBasics ~/.julia/packages/GeometryBasics/ebuW5/src/basic_types.jl:296
  ...

Stacktrace:
 [1] Polygon(exterior::SVector{3, Point{2, Float64}})
   @ GeometryBasics ~/.julia/packages/GeometryBasics/ebuW5/src/basic_types.jl:296
 [2] top-level scope
   @ REPL[40]:1

julia> Polygon(Array(p))
Polygon{2, Float64}(Point{2, Float64}[[1.0, 1.0], [2.0, 2.0], [0.2, 2.0]], Vector{Point{2, Float64}}[])

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions