-
-
Notifications
You must be signed in to change notification settings - Fork 56
Fix #88: add boundbox operation #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @SimonDanisch is this PR ok? I am waiting on your approval to continue with more PRs. |
Iooks ok, although will be a relatively big breaking change ;) |
I think we will need some more like these before a GeometryBasics.jl v1.0.0 :) I am doing my best to break things as early as possible in favor of a cleaner, more maintainable codebase.
I thought that |
Done :) Please let me know if you prefer the longer |
Yeah, definitely prefer the longer one :) No need to be greedy here ;) |
Master needs to be always taggable - since I don't immediately want to tag a breaking 1.0, I'd prefer not merging any of these. |
So it is better to tag breaking changes in a separate branch? Could you please advise on how I should proceed? I understood I should close this PR, and instead work on a separate branch of the repo until things settle down. Isn't it more painful to break everything at once when this big merge occurs as opposed to little breaking changes every now and then? The plan is to tag v0.4, v0.5, v0.6, ... until we get stable enough for a 1.0. Would that be ok? I will rename back to boundingboxes.jl as suggested. |
tagging a breaking releases has lots of organisational overhead for me, due to all the dependencies of GeometryBasics, which I mostly maintain alone. Since the changes are usually relatively small per package, I prefer to do multiple ones in one go. I'd just create a new branch, and change the base of this branch against that, which should be pretty easy with github ;) |
Makes sense. I will try to follow the rebase instructions to move the changes over a new branch. |
This PR refactors the bounding box operation as discussed in #88. After it is reviewed and merged, I can start working on other improvements to the codebase.