Skip to content

check buchheim assumtions #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2022
Merged

check buchheim assumtions #34

merged 3 commits into from
Jan 6, 2022

Conversation

hexaeder
Copy link
Collaborator

@hexaeder hexaeder commented Aug 5, 2021

graph has to be "rooted tree"

  • node 1 is root
  • unique pathes (only 1 parent per node)
  • all nodes can be reached

fixes #9

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #34 (7d5afe3) into master (63c5fcf) will decrease coverage by 0.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   98.02%   97.44%   -0.58%     
==========================================
  Files           8        8              
  Lines         455      470      +15     
==========================================
+ Hits          446      458      +12     
- Misses          9       12       +3     
Impacted Files Coverage Δ
src/buchheim.jl 97.19% <100.00%> (-1.60%) ⬇️
src/sfdp.jl 98.30% <0.00%> (+0.02%) ⬆️
src/NetworkLayout.jl 94.44% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c5fcf...7d5afe3. Read the comment docs.

@hexaeder hexaeder requested a review from SimonDanisch August 5, 2021 17:17
@hexaeder hexaeder mentioned this pull request Dec 7, 2021
@hexaeder hexaeder linked an issue Dec 7, 2021 that may be closed by this pull request
@hexaeder
Copy link
Collaborator Author

hexaeder commented Dec 7, 2021

Hey @SimonDanisch, what do you think? I totally forgot about that one :D
This might be slow for very big graphs. This might be also breaking for some cases (there are cases where the old Buchheim gives results even though some of the assumptions are broken.
Not having those assumptions might lead to infinite loops or strange errors. I'd say merge and tag minor 🤷‍♂️

@hexaeder hexaeder merged commit 9a56eff into master Jan 6, 2022
@hexaeder hexaeder deleted the hw/buchheim_checks branch January 6, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackOverflow Detect cycles in Buchheim
1 participant