Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Fix: ClassParser's Boolean parser when type is Long #464

Merged
merged 1 commit into from
Nov 9, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions anko/library/robolectricTests/src/test/java/ClassParserTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,19 @@ class ClassParserTest {
classParser<Class10>()

assertThrows { classParser<Class11>() }

with (classParser<Class12>()) {
arrayOf<Any?>(0).also {
val clTrue = Class12(true)
val clFalse = Class12(false)

assertEquals(clFalse, parseRow(it))
assertEquals(clFalse, parseRow(arrayOf(0L)))

assertEquals(clTrue, parseRow(arrayOf(1)))
assertEquals(clTrue, parseRow(arrayOf(1L)))
}
}
}

data class Class1(val s: String, val l: Long, val d: Double?)
Expand Down Expand Up @@ -102,4 +115,6 @@ class ClassParserTest {
}
throw AssertionError("Exception was not thrown")
}

data class Class12(val b: Boolean)
}
2 changes: 1 addition & 1 deletion anko/library/static/sqlite/src/ClassParser.kt
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ private fun castValue(value: Any?, type: Class<*>): Any? {
} else if (type == java.lang.Byte.TYPE || type == java.lang.Byte::class.java) {
return value.toByte()
} else if (type == java.lang.Boolean.TYPE || type == java.lang.Boolean::class.java) {
return value != 0
return value != 0L
} else if (type == java.lang.Character.TYPE || type == java.lang.Character::class.java) {
return value.toChar()
}
Expand Down