chore: clean up silent flag

Author: gpabst

pkg/internal/common/flags/common.go

@@ -14,6 +14,5 @@ func GetSignerFlags() []cli.Flag {
 		&FireblocksTimeoutFlag,
 		&FireblocksSecretStorageTypeFlag,
 		&Web3SignerUrlFlag,
-		&SilentFlag,
 	}
 }

pkg/internal/common/flags/general.go

@@ -79,7 +79,7 @@ var (
 	SilentFlag = cli.BoolFlag{
 		Name:    "silent",
 		Aliases: []string{"s"},
-		Usage:   "Suppress unnecessary output (except for claim data to enable piping)",
+		Usage:   "Suppress unnecessary output",
 		EnvVars: []string{"SILENT"},
 	}
 )

pkg/rewards/claim.go

@@ -74,6 +74,7 @@ func getClaimFlags() []cli.Flag {
 		&ClaimTimestampFlag,
 		&ProofStoreBaseURLFlag,
 		&flags.VerboseFlag,
+		&flags.SilentFlag,
 	}
 
 	allFlags := append(baseFlags, flags.GetSignerFlags()...)
@@ -373,7 +374,7 @@ func readAndValidateClaimConfig(cCtx *cli.Context, logger logging.Logger) (*Clai
 	splitTokenAddresses := strings.Split(tokenAddresses, ",")
 	validTokenAddresses := getValidHexAddresses(splitTokenAddresses)
 	rewardsCoordinatorAddress := cCtx.String(RewardsCoordinatorAddressFlag.Name)
-	isSilent := cCtx.Bool(SilentFlag.Name)
+	isSilent := cCtx.Bool(flags.SilentFlag.Name)
 
 	var err error
 	if common.IsEmptyString(rewardsCoordinatorAddress) {

pkg/rewards/flags.go

@@ -91,11 +91,4 @@ var (
 		Value:   "all",
 		EnvVars: []string{"REWARDS_CLAIM_TYPE"},
 	}
-
-	SilentFlag = cli.BoolFlag{
-		Name:    "silent",
-		Aliases: []string{"s"},
-		Usage:   "Suppress output except for claim",
-		EnvVars: []string{"REWARDS_CLAIM_SILENT"},
-	}
 )