Skip to content

tests: add tests for some calculations #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2024
Merged

tests: add tests for some calculations #231

merged 2 commits into from
Oct 19, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Oct 19, 2024 •
edited
Loading

Fixes # .

What Changed?

  • Add tests where calculation can get buggy
  • Fix some other bugs

bdchatham
bdchatham approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@bdchatham bdchatham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests! :D

@shrimalmadhur
Copy link
Collaborator Author

Thanks for adding the tests! :D

Yeah! Need to keep adding and need a lot of refactor!

@shrimalmadhur shrimalmadhur merged commit 39cf782 into master Oct 19, 2024
8 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/some-show-tests branch October 19, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdchatham bdchatham bdchatham approved these changes

@gpabst gpabst Awaiting requested review from gpabst

@nelsonijih nelsonijih Awaiting requested review from nelsonijih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @bdchatham