Skip to content

Bugfix/rewards uam support #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 5, 2025
Merged

Bugfix/rewards uam support #294

merged 6 commits into from
Mar 5, 2025

Conversation

bdchatham
Copy link
Contributor

Fixes

  • Fixes rewards commands to specify a CallerAddress to support printing call data.
  • Refactors call data writeable commands to all implement a BaseCommand and wrap it in a CalldataWriteableCommand to generalize flag handling and command creation.
  • Small simplifications to reuse existing helper functions.

What Changed?

  • BaseCommand and CalldataWriteableCommand introduced to generalize command handling.

@bdchatham bdchatham requested a review from gpabst March 4, 2025 17:51
gpabst
gpabst approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@gpabst gpabst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as we discussed may in the future want to have the caller address auto populated based on the passed in private key

@bdchatham bdchatham merged commit 10fe3ae into Layr-Labs:feat/slashing Mar 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpabst gpabst gpabst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdchatham @gpabst