PR: Fix Duplicate Metric Logging in MLFlowLogger to Prevent MLflow Database Errors #20871
+61
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a long standing issue in PyTorch Lightning’s MLFlowLogger where logging the same metric (with the same name and step) more than once in a run causes a unique constraint violation on certain MLflow backends (e.g., PostgreSQL).
Now, MLFlowLogger tracks (metric, step) pairs and skips any duplicate metric logs within a run, preventing database errors and improving robustness.
This change also updates the class docstring to document this new behavior and adds a unit test to verify that duplicate metric logs are ignored as expected.
Fixes #20865
Motivation and Context
Dependencies
Does your PR introduce any breaking changes?
Other Checklist Items
Documentation updated- yes(see class docstring in MLFlowLogger)
New test added for deduplication- yes
Fun fact:
This change will help Lightning users avoid subtle training failures, especially with remote or production MLflow tracking servers!
📚 Documentation preview 📚: https://pytorch-lightning--20871.org.readthedocs.build/en/20871/