-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Implement todos tensorboard #20874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement todos tensorboard #20874
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20874 +/- ##
=========================================
- Coverage 87% 49% -38%
=========================================
Files 268 265 -3
Lines 23414 23358 -56
=========================================
- Hits 20363 11407 -8956
- Misses 3051 11951 +8900 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test now covers plain nn.Module and _FabricModule cases.
The other focuses on LightningModule with batch transfer hooks.
perfect, thank you @KAVYANSHTYAGI |
What does this PR do?
This change ensures more robust and realistic validation of the logging graph functionality, especially for models that go through Fabric’s module wrapping and transfer pipeline.
Was this discussed/agreed via a GitHub issue? (not for typos and docs)no
Did you read the contributor guideline, Pull Request section?yes
Did you make sure your PR does only one thing, instead of bundling different changes together?yes
Did you make sure to update the documentation with your changes? (if necessary)no
Did you write any new necessary tests? (not for typos and docs)no
Did you verify new and existing tests pass locally with your changes?yes
Did you list all the breaking changes introduced by this pull request?yes
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)no
PR review
Anyone in the community is welcome to review the PR.
📚 Documentation preview 📚: https://pytorch-lightning--20874.org.readthedocs.build/en/20874/