-
Notifications
You must be signed in to change notification settings - Fork 16
manylinux_2_24: Use gcc-9 & binutils 2.36.1 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is still a problem on ppc64, |
All checks passed 🎉. Do you want to remove the "Draft" status? |
Sorry but I kind of hi-jacked this PR to see what could be done with custom PPA... I do feel comfortable using the gcc-9 PPA from the debian/ubuntu folks and rebuilding binutils from source as was once tried in this PR. As you noted, it will require bumping OpenBLAS to get past the power10 issue on ppc64le. I will update the PR this way. |
Thanks! |
0d1f526
to
2b103ce
Compare
Use gcc-9 from ubuntu-toolchain-r/test PPA: A gcc toolchain recent enough is required to build OpenBLAS aarch64 code. Use "official" backport of gcc 9.3.0 toolchain for Xenial instead of default 6.3.0 toolchain on Debian 9. No symbol conflicts observed for OpenBLAS & its dependencies when using this toolchain. Use binutils 2.36.1 rebuilt from source: A recent enough assembler is needed to build OpenBLAS code. Replaces the 2.28 binutils on Debian 9
Fix build issue with gcc-9 on ppc64le
bd4f9b6
to
bd2abcf
Compare
I cleaned this up a bit. |
I think it is a protection against cryptocurrency mining (seriously). Anyway, I approved the CI to run--I think this only happens first time for new contributor. |
I think this should be good to go. I am not sure what to do about the g++ compatibility issue, it will be a blocker for actually releasing manylinux2_24 wheels, since SciPy, and soon NumPy, use c++ code. |
Closing. the g++ issue prevents manylinux2_24 wheels from being viable. |
c.f. #54 & pypa/manylinux#1012 (comment)
Use gcc-9 from ubuntu-toolchain-r/test PPA:
A gcc toolchain recent enough is required to build OpenBLAS aarch64 code.
Use "official" backport of gcc 9.3.0 toolchain for Xenial instead of default 6.3.0 toolchain on Debian 9.
No symbol conflicts observed for OpenBLAS & its dependencies when using this toolchain.
Use binutils 2.36.1 rebuilt from source:
A recent enough assembler is needed to build OpenBLAS code.
Replaces the 2.28 binutils on Debian 9