-
Notifications
You must be signed in to change notification settings - Fork 26
Update StreakScore.jsx #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: working
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bon changement
}; | ||
|
||
// Function to handle streak score calculation considering "Abs" | ||
const calculateStreakScore = (scores) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@@ -1,4 +1,4 @@ | |||
import { useState, useEffect, useRef, useContext } from 'react' | |||
import { useState, useEffect, useRef, useContext } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;
optionnel mais OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Comme je l'avais déjà dit on n'accepte pas de pull request avant la fin de refactor désolé. |
Problème résolu
Correction d'un bug où une note après un "Abs" n'augmentait pas le streak.
Modifications apportées
Ajout d'une logique pour inclure une note après un "Abs" dans le calcul du streak.
Modification de la fonction calculateStreakScore dans le fichier StreakScore.jsx pour gérer correctement les notes après un "Abs".
Détails techniques
Ajout de la fonction calculateStreakScore pour traiter les scores et calculer le streak en prenant en compte les notes après un "Abs" ou "Disp".
fichier
StreakScore.jsx
modifier