Skip to content

Update StreakScore.jsx #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: working
Choose a base branch
from

Conversation

Super-Code774
Copy link
Contributor

@Super-Code774 Super-Code774 commented Feb 25, 2025

Problème résolu

Correction d'un bug où une note après un "Abs" n'augmentait pas le streak.

Modifications apportées

Ajout d'une logique pour inclure une note après un "Abs" dans le calcul du streak.
Modification de la fonction calculateStreakScore dans le fichier StreakScore.jsx pour gérer correctement les notes après un "Abs".

Détails techniques

Ajout de la fonction calculateStreakScore pour traiter les scores et calculer le streak en prenant en compte les notes après un "Abs" ou "Disp".
fichier StreakScore.jsx modifier

@Super-Code774 Super-Code774 marked this pull request as ready for review February 25, 2025 08:37
Copy link

@gHVGTCHTY66 gHVGTCHTY66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon changement

};

// Function to handle streak score calculation considering "Abs"
const calculateStreakScore = (scores) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@@ -1,4 +1,4 @@
import { useState, useEffect, useRef, useContext } from 'react'
import { useState, useEffect, useRef, useContext } from 'react';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

; optionnel mais OK

Copy link

@Hidden495 Hidden495 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@saumon-brule
Copy link
Member

Comme je l'avais déjà dit on n'accepte pas de pull request avant la fin de refactor désolé.

@xav35000 xav35000 added type:logic Affects the back of the project (logic part) size:XS PR size: extra small priority:2 Low priority level pending Reviewed but wait before merging for various reasons labels Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Reviewed but wait before merging for various reasons priority:2 Low priority level size:XS PR size: extra small type:logic Affects the back of the project (logic part)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants