Skip to content

Add list of hosts with ports for setting connection #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add list of hosts with ports for setting connection #1

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0d87218
Add setting host list and round robin prototype
df530 Nov 22, 2021
0b74858
Add timeout and tests (not debugged)
df530 Nov 23, 2021
d713ce7
Some changes, not fixed test, but improve action
df530 Nov 29, 2021
0f2da33
Fix tests
df530 Dec 13, 2021
25b7fdc
Delete extra changes
df530 Dec 13, 2021
662a27d
Fix review comments
df530 Dec 21, 2021
53affd2
Divided catch (...) block
df530 Dec 31, 2021
fabac4d
Add descriptioin of feature to README
df530 Jan 10, 2022
edf5421
Fix font size
df530 Jan 10, 2022
563b7b6
merge new feature with master
df530 Jan 11, 2022
13294d3
Delete unused operator== overload
df530 Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete extra changes
  • Loading branch information
@df530
df530 committed Dec 13, 2021
commit 25b7fdce699001ad353069b171036b08b3e4b8f5
4 changes: 2 additions & 2 deletions clickhouse/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ class Client::Impl {

};


const ClientOptions options_;
QueryEvents* events_;
int compression_ = CompressionState::Disable;
Expand Down Expand Up @@ -291,8 +292,7 @@ void Client::Impl::ResetConnection() {
for (size_t i = 0; i < options_.hosts_ports.size(); ++i) {
try {
const ClientOptions::HostPort& host_port = options_.hosts_ports[i];
NetworkAddress na = NetworkAddress(host_port.host, std::to_string(host_port.port.value_or(options_.port)));
SocketHolder s(SocketConnect(na));
SocketHolder s(SocketConnect(NetworkAddress(host_port.host, std::to_string(host_port.port.value_or(options_.port)))));

if (s.Closed()) {
throw std::system_error(errno, std::system_category());
Expand Down