Removed unnecessary rotation from example #2438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why it failed? Apparently the test was exited because of a time out |
|
I think the build failure was random. However, I'm not sure whether the two rotations are really needed in these two examples--what do you think about removing them? |
|
@behackl sure, I will remove it them. |
behackl
approved these changes
Jan 10, 2022
|
@Mergifyio squash |
…nim/manim/mobject/types/vectorized_mobject.py and opengl_vectorized_mobject.py) (ManimCommunity#2438) Add missing () in the files reported in issue ManimCommunity#2389 * Quick fix * Quick fix * Removing .rotate() * Removing .rotate() * Merge branch 'main' into fix-issue-2389 * Merge branch 'main' into fix-issue-2389
✅ Pull request squashed successfully |
Darylgolden
force-pushed
the
fix-issue-2389
branch
from
6a95c2b to
48fa350
Compare
|
Oops, not what I meant to do... |
|
@Mergifyio merge |
|
Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
Darylgolden
changed the title
behackl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
vectorized_mobject.pyandopengl_vectorized_mobject.pyMotivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Any changed documentation pages
Further Information and Comments
Any additional details
Reviewer Checklist