Experimenting with an HSV class #3518
Conversation
MrDiver
added
new feature
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…tween color spaces over proxy rgba
MrDiver
changed the title
There was a problem hiding this comment.
Nice! I'm really liking it, as well as the color conversion utilities (.into gives Rust Into::into vibes, which I love)!
I left some comments, so I would appreciate it if you could take a look.
Additionally, do you think it's a good idea to enable mypy for this file? It seems like it should be fine from my brief glance though.
|
|
||
|
|
||
| def test_into_HSV() -> None: | ||
| nt.assert_equal(RED.into(HSV).into(ManimColor), RED) |
There was a problem hiding this comment.
Is adding colors/performing other operations on colors supported? Those might also be good tests to make sure it works for both ManimColor and other color spaces (HSV).
There was a problem hiding this comment.
yip, just haven't written the tests by now and still unsure of how useful it would be, but it works!
Surely, that should be fine, i had it enabled i think when writing it. |
Co-authored-by: adeshpande <[email protected]>
Co-authored-by: adeshpande <[email protected]>
Co-authored-by: adeshpande <[email protected]>
Co-authored-by: adeshpande <[email protected]>
MrDiver
force-pushed
the
color_experiments
branch
from
8cefae8 to
a38cf7f
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Aarush Deshpande <[email protected]>
Co-authored-by: Aarush Deshpande <[email protected]>
Co-authored-by: Aarush Deshpande <[email protected]>
Co-authored-by: Aarush Deshpande <[email protected]>
for more information, see https://pre-commit.ci
Attempt at finding a useful solution for different color spaces
fixes #3485