Allow videos to be embedded in Google Colab without explicitly setting config.media_embed = True
#3974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skusel
changed the title
3 tasks
chopan050
changed the title
config.media_embed = True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Allows videos to be embedded when running in Google Colab without having to explicitly set the media_embed configuration option to True.
Motivation and Explanation: Why and how do your changes improve the library?
Addresses #3741
Links to added or changed documentation pages
N/A
Further Information and Comments
After making this change, I created a whl using
poetry build, uploaded it to Google Colab, pip installed the whl, and confirmed it displayed the embedded video.Reviewer Checklist