Add support in documentation for type aliases using Python 3.12 type definition
#4044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopan050
changed the title
type syntaxtype definition
JasonGrace2282
added a commit
to JasonGrace2282/manim
that referenced
this pull request
Dec 6, 2024
behackl
pushed a commit
to JasonGrace2282/manim
that referenced
this pull request
Jan 19, 2025
behackl
added a commit
that referenced
this pull request
Jan 20, 2025
* First draft of Changelog for 0.19.0 * fix typos * added 3967 * Add #4037 * Update count 97 -> 98 * Add #4039 * Add #3930 and #4044 * Add this PR to changelog * Add small description to changelog * Add #3924, #3951, and #4038 * Bump Manim version to 0.19.0 * Update CITATION.cff to be more consistent * remove github-security[bot] * Feedback + missing PRs * add newly merged PRs * added more details to highlights + breaking changes * bump date * sort PRs in breaking changes section and include 3964 * sort highlights section * fix: add required configuration key in .readthedocs.yml * Update docs/source/changelog/0.19.0-changelog.rst --------- Co-authored-by: Benjamin Hackl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3772
I tested it by adding new type aliases and rewriting old ones with the new
typesyntax and it worked fine, in the same way as it does with ourTypeAlias-annotated assignments. However, I must note that, when attempting to definetype ManimFloat = np.float64, Manim crashes with aTypeError: Cannot interpret 'ManimFloat' as a data type.Reviewer Checklist