Skip to content

MDBF-1078 Ubuntu 20.04 is EOL #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

RazvanLiviuVarzaru
Copy link
Collaborator

@RazvanLiviuVarzaru RazvanLiviuVarzaru commented May 19, 2025

  • docker library - needs bump 10.6 to jammy in docker gh project
  • remove release ub2004 builders (os-info)
  • bump ubuntu to 22.04 for integration testing builders: eco-php
  • bump ubuntu to 22.04 for special builders:
    • debug (all arches) - remove amd64 2004 builder from protected branches before prod deploy
    • big-test (amd64)
    • full - test (amd64)
    • without server (ppc) - Solved in 6b29365

10.5 is no longer supported, start SUPPORTED_PLATFORMS from 10.6 - Solved in #765

Copy link
Member

@grooverdan grooverdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good. Guess we'll see who the eco-php goes.

Could remove 10.5 out of the gridview.

maps to what I was planning on the Docker Official Images side - MariaDB/mariadb-docker#553

@grooverdan
Copy link
Member

MariaDB/mariadb-docker#645 for merging at the same time as the CI starts triggering the docker-library worker from jammy.

@RazvanLiviuVarzaru
Copy link
Collaborator Author

MariaDB/mariadb-docker#645 for merging at the same time as the CI starts triggering the docker-library worker from jammy.

So when this patch reaches buildbot production, right?

@grooverdan
Copy link
Member

MariaDB/mariadb-docker#645 for merging at the same time as the CI starts triggering the docker-library worker from jammy.

So when this patch reaches buildbot production, right?

yes. BB production.

@grooverdan
Copy link
Member

MariaDB/mariadb-docker#645 for merging at the same time as the CI starts triggering the docker-library worker from jammy.

So when this patch reaches buildbot production, right?

yes. BB production.

No need to rush the on the MariaDB/mariadb-docker#645 merge. It will only impact 10.6 pushes which don't happen too often. @fauust and @vl-radu have push rights there when needed (and actually all server developers - which I may reconsider at some stage soon).

RazvanLiviuVarzaru added a commit to RazvanLiviuVarzaru/buildbot-r that referenced this pull request Jun 12, 2025
This patch is targeted for buildbot release v1.0.7
I know I had an attempt to cover it in
MariaDB#756

but I don't like getting merge conflicts on constants.py.
so it's better to separate the concerns a bit,
remove 10.5 and then handle any platform deprecation / addition.
RazvanLiviuVarzaru added a commit to RazvanLiviuVarzaru/buildbot-r that referenced this pull request Jun 12, 2025
This patch is targeted for buildbot release v1.0.7
I know I had an attempt to cover it in MariaDB#756

but I don't like getting merge conflicts on constants.py.
so it's better to separate the concerns a bit,
remove 10.5 and then handle any platform deprecation / addition.
RazvanLiviuVarzaru added a commit to RazvanLiviuVarzaru/buildbot-r that referenced this pull request Jun 12, 2025
This patch is targeted for buildbot release v1.0.7
I know I had an attempt to cover it in MariaDB#756

but I don't like getting merge conflicts on constants.py.
so it's better to separate the concerns a bit,
remove 10.5 and then handle any platform deprecation / addition.
RazvanLiviuVarzaru added a commit to RazvanLiviuVarzaru/buildbot-r that referenced this pull request Jun 12, 2025
This patch is targeted for buildbot release v1.0.7
I know I had an attempt to cover it in MariaDB#756

but I don't like getting merge conflicts on constants.py.
so it's better to separate the concerns a bit,
remove 10.5 and then handle any platform deprecation / addition.
RazvanLiviuVarzaru added a commit to RazvanLiviuVarzaru/buildbot-r that referenced this pull request Jun 13, 2025
This patch is targeted for buildbot release v1.0.7
I know I had an attempt to cover it in MariaDB#756

but I don't like getting merge conflicts on constants.py.
so it's better to separate the concerns a bit,
remove 10.5 and then handle any platform deprecation / addition.
RazvanLiviuVarzaru added a commit that referenced this pull request Jun 13, 2025
This patch is targeted for buildbot release v1.0.7
I know I had an attempt to cover it in #756

but I don't like getting merge conflicts on constants.py.
so it's better to separate the concerns a bit,
remove 10.5 and then handle any platform deprecation / addition.
1. Remove the release builders
2. Docker Library - 10.6 on 2204
3. Upgrade dependent builders:
    - Bump Ubuntu to 22.04 for integration testing builders: `eco-php`
    - Bump Ubuntu to 22.04 for special builders: debug, big-test, full-test

Make sure to remove amd64-ubuntu-2004-debug from branch protection and add 2204 instead.
@RazvanLiviuVarzaru RazvanLiviuVarzaru changed the title draft - remove 10.5 support and remove eol ub2004 MDBF-1078 Ubuntu 20.04 is EOL Jun 26, 2025
@RazvanLiviuVarzaru RazvanLiviuVarzaru marked this pull request as ready for review June 26, 2025 10:10
- fixed runtime deps for mariadb in ubuntu 22.04 container
- fixed build-time deps for php in 22.04 container

PHP 7.1 won't compile on 22.04 container but it's EOL anyway.
- updated the list with only supported versions. See: https://www.php.net/supported-versions
@RazvanLiviuVarzaru
Copy link
Collaborator Author

RazvanLiviuVarzaru commented Jun 26, 2025

@grooverdan this patch is ready for your final review.
Please have a look at c468a36
I thought upgrading PHP builder container image would be less time consuming but I was wrong!

How to test c468a36

docker run -it --rm docker push quay.io/rvarzaru/test:php_ubuntu_2204 bash
sh -xc 'curl https://raw.githubusercontent.com/MariaDB/buildbot/main/dockerfiles/ecofiles/installdb.sh -o /buildbot/installdb.sh && chmod a+x /buildbot/installdb.sh
sh -xc 'curl https://raw.githubusercontent.com/MariaDB/buildbot/main/dockerfiles/ecofiles/test-php.sh -o /buildbot/test-php.sh && chmod a+x /buildbot/test-php.sh'
/buildbot/installdb.sh https://ci.mariadb.org/57746/amd64-ubuntu-2204/mariadb-11.8.3-linux-x86_64.tar.gz --plugin-load-add=auth_pam --pam_use_cleartext_plugin
mkdir /code
mkdir /build
sh -xc '/buildbot/test-php.sh PHP-8.1'

Note: maybe you know better why is this happening:
when building 8.1 -> 8.2 -> 8.3 (OK)
and when I try to build the master branch I need to ./buildconf --force because the configure script is no longer present.
Should I add ./buildconf --force in the test script for every test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants