-
-
Notifications
You must be signed in to change notification settings - Fork 234
Add gasFeeEstimates
for batch transactions
#5886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+228
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a publish batch hook
Co-authored-by: Matthew Walsh <[email protected]>
…:MetaMask/core into feat/add-batch-transaction-approval-type
…-estimate-gas-batch-transaction
…-estimate-gas-batch-transaction
…-estimate-gas-batch-transaction
OGPoyraz
previously approved these changes
Jun 6, 2025
pedronfigueiredo
previously approved these changes
Jun 6, 2025
316f3d8
pedronfigueiredo
previously approved these changes
Jun 6, 2025
OGPoyraz
previously approved these changes
Jun 9, 2025
OGPoyraz
previously approved these changes
Jun 11, 2025
pedronfigueiredo
previously approved these changes
Jun 11, 2025
9204df6
OGPoyraz
approved these changes
Jun 11, 2025
pedronfigueiredo
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR enhances
TransactionBatchMeta
by adding support forgasFeeEstimates
andstatus
.When both
useHook
andrequireApproval
aretrue
, the batch approval flow is triggered, andgasFeeEstimates
are populated using theDefaultGasFeeFlow
. These estimates are then passed along with the request to be consumed by the client.Changes
TransactionBatchMeta
to include:gasFeeEstimates
status
prepareApprovalData
References
Changelog
Checklist