Skip to content

Feat: 1.3 new create import srp #15669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 122 commits into from
Jun 4, 2025
Merged

Conversation

ieow
Copy link
Contributor

@ieow ieow commented May 26, 2025

Description

1.3
Update New SRP onboarding flow as per figma design
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=434-55200&t=wmEoQSF9g9lFtkwp-0

This PR is part 3 of 7 for the new SRP ui update

This PR cover

  • new ui create srp
  • new ui for import srp

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-05-24.at.5.34.07.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@smgv smgv changed the title Feat/new create import srp Feat: 1.2 new create import srp May 27, 2025
@chaitanyapotti chaitanyapotti changed the title Feat: 1.2 new create import srp Feat: 1.3 new create import srp May 27, 2025
@chaitanyapotti chaitanyapotti added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 48d1bad
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4f9b5008-28c5-4638-b92f-3e500b8e4b69

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ieow ieow added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 99cb3ab
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2b67c6d2-2d3c-4fdf-aff7-21637cc5008b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@smgv smgv added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a729cca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60bb62c0-f8a7-4833-93c2-5f2998b34b42

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Jun 4, 2025

@github-project-automation github-project-automation bot moved this from Needs more work from the author to Review finalised - Ready to be merged in PR review queue Jun 4, 2025
@chaitanyapotti chaitanyapotti enabled auto-merge June 4, 2025 15:33
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit cb1ebf5 Jun 4, 2025
49 of 52 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/new-create-import-srp branch June 4, 2025 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-onboarding No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 Run Smoke E2E Requires smoke E2E testing team-web3auth
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants