Skip to content

Create TabbedCommandBar.md #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Conversation

yoshiask
Copy link
Contributor

@yoshiask yoshiask commented Nov 3, 2020

Docs for Toolkit PR #3551

What changes to the docs does this PR provide?

Adds documentation for the TabbedCommandBar control

PR Checklist

Please check if your PR fulfills the following requirements:

  • Correctly picked the right branch to base the change off (master for new features, live for typos/improvements)
  • For new pages, used the provided template
  • For new features, added an entry in the Table of Contents
  • Ran against a spell and grammar checker
  • Contains NO breaking changes

Other information

Started writing the documentation for [TabbedCommandBar](CommunityToolkit/WindowsCommunityToolkit#3551)
@opbld30
Copy link

opbld30 commented Nov 3, 2020

Docs Build status updates of commit 51bb022:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ⚠️Warning View Details

docs/controls/TabbedCommandBar.md

  • Line 88, Column 2: [Warning-file-not-found] Invalid file link: '../resources/images/Controls/TabbedCommandBar/Overview.gif'.
  • Line 184, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.collections.objectmodel.observablecollection-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 188, Column 1: [Warning-insecure-link] Link 'http://aka.ms/uwptoolkitapp' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.
  • Line 207, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.collections.objectmodel.observablecollection-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 208, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/Windows.UI.Xaml.Controls.IconElement' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 209, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.windows.controls.tabcontrol' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@LanceMcCarthy
Copy link
Contributor

Reviewing

@yoshiask
Copy link
Contributor Author

yoshiask commented Dec 5, 2020

@LanceMcCarthy I appreciate the review, but this PR is marked as a draft because the content is just a duplicate of the TabView docs. Nothing in this PR is actually for the TabbedCommandBar, because the features and API surface is still in development and can change a lot.

@opbld32
Copy link

opbld32 commented Feb 8, 2021

Docs Build status updates of commit 6552f78:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/BackButtonBehavior.xml ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Win32.UI.Controls.Interop.WinRT/WebViewControlPermissionType.xml ⚠️Warning View Details
docs/extensions/ListViewBase.md ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Uwp.UI.Lottie/LottieVisualSource.xml ⚠️Warning View Details
docs/toc.md ✅Succeeded View

docs/controls/TabbedCommandBar.md

  • Line 88, Column 2: [Warning-file-not-found] Invalid file link: '../resources/images/Controls/TabbedCommandBar/Overview.gif'.
  • Line 184, Column 30: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.collections.objectmodel.observablecollection-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 188, Column 224: [Warning-insecure-link] Link 'http://aka.ms/uwptoolkitapp' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.
  • Line 207, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.collections.objectmodel.observablecollection-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 208, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/Windows.UI.Xaml.Controls.IconElement' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 209, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.windows.controls.tabcontrol' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/BackButtonBehavior.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Core.SystemNavigationManager'.

dotnet/xml/Microsoft.Toolkit.Win32.UI.Controls.Interop.WinRT/WebViewControlPermissionType.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Web.UI.WebViewControlPermissionType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Web.UI.WebViewControlPermissionType'.

docs/extensions/ListViewBase.md

  • Line 11, Column 102: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 17, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 29, Column 83: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.datatemplate' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 31, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 56, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 68, Column 3: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/p/?LinkID=526370' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

dotnet/xml/Microsoft.Toolkit.Uwp.UI.Lottie/LottieVisualSource.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisual'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Composition.Compositor'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisualSource.TryCreateAnimatedVisual(Windows.UI.Composition.Compositor,System.Object@)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyProperty'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Storage.StorageFile'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyObject'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.ActivatableAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.MarshalingBehaviorAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.StaticAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.ThreadingAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.VersionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Uri'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IAsyncAction'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Uri'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.OverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IAsyncAction'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Storage.StorageFile'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.DefaultOverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.OverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.TypedEventHandler`2'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource.AnimatedVisualInvalidated'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyProperty'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@yoshiask
Copy link
Contributor Author

yoshiask commented Feb 8, 2021

Which properties should I list for each control (TabbedCommandBar and TabbedCommandBarItem)? The TabbedCommandBar doesn't add any properties, it just uses existing NavigationView properties.

@opbld31
Copy link

opbld31 commented Feb 8, 2021

Docs Build status updates of commit 8f018ab:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/BackButtonBehavior.xml ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Win32.UI.Controls.Interop.WinRT/WebViewControlPermissionType.xml ⚠️Warning View Details
docs/extensions/ListViewBase.md ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Uwp.UI.Lottie/LottieVisualSource.xml ⚠️Warning View Details
docs/toc.md ✅Succeeded View

docs/controls/TabbedCommandBar.md

  • Line 128, Column 2: [Warning-file-not-found] Invalid file link: '../resources/images/Controls/TabbedCommandBar/Overview.gif'.
  • Line 226, Column 251: [Warning-insecure-link] Link 'http://aka.ms/uwptoolkitapp' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/BackButtonBehavior.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Core.SystemNavigationManager'.

dotnet/xml/Microsoft.Toolkit.Win32.UI.Controls.Interop.WinRT/WebViewControlPermissionType.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Web.UI.WebViewControlPermissionType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Web.UI.WebViewControlPermissionType'.

docs/extensions/ListViewBase.md

  • Line 11, Column 102: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 17, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 29, Column 83: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.datatemplate' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 31, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 56, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 68, Column 3: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/p/?LinkID=526370' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

dotnet/xml/Microsoft.Toolkit.Uwp.UI.Lottie/LottieVisualSource.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Storage.StorageFile'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyProperty'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IAsyncAction'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Uri'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.OverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IAsyncAction'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Storage.StorageFile'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.DefaultOverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.OverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyProperty'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyObject'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.ActivatableAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.MarshalingBehaviorAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.StaticAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.ThreadingAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.VersionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.TypedEventHandler`2'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource.AnimatedVisualInvalidated'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisual'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Composition.Compositor'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisualSource.TryCreateAnimatedVisual(Windows.UI.Composition.Compositor,System.Object@)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Uri'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable.ToString'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@yoshiask yoshiask marked this pull request as ready for review February 9, 2021 00:11
@opbld31
Copy link

opbld31 commented Feb 9, 2021

Docs Build status updates of commit ac7538b:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/BackButtonBehavior.xml ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Win32.UI.Controls.Interop.WinRT/WebViewControlPermissionType.xml ⚠️Warning View Details
docs/extensions/ListViewBase.md ⚠️Warning View Details
dotnet/xml/Microsoft.Toolkit.Uwp.UI.Lottie/LottieVisualSource.xml ⚠️Warning View Details
docs/resources/images/Controls/TabbedCommandBar.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

docs/controls/TabbedCommandBar.md

  • Line 226, Column 251: [Warning-insecure-link] Link 'http://aka.ms/uwptoolkitapp' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/BackButtonBehavior.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Core.SystemNavigationManager'.

dotnet/xml/Microsoft.Toolkit.Win32.UI.Controls.Interop.WinRT/WebViewControlPermissionType.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Web.UI.WebViewControlPermissionType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Web.UI.WebViewControlPermissionType'.

docs/extensions/ListViewBase.md

  • Line 11, Column 102: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 17, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 29, Column 83: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.datatemplate' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 31, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 56, Column 16: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewbase#Windows_UI_Xaml_Controls_ListViewBase_ContainerContentChanging' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 68, Column 3: [Warning-insecure-link] Link 'http://go.microsoft.com/fwlink/p/?LinkID=526370' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

dotnet/xml/Microsoft.Toolkit.Uwp.UI.Lottie/LottieVisualSource.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyObject'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.ActivatableAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyProperty'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.MarshalingBehaviorAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.StaticAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.ThreadingAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.VersionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Storage.StorageFile'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisual'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Composition.Compositor'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IAnimatedVisualSource.TryCreateAnimatedVisual(Windows.UI.Composition.Compositor,System.Object@)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.TypedEventHandler`2'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource.AnimatedVisualInvalidated'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IStringable.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IAsyncAction'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Uri'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.OverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.IAsyncAction'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Storage.StorageFile'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.DefaultOverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Metadata.OverloadAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.Foundation.Uri'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Windows.UI.Xaml.DependencyProperty'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

ghost pushed a commit to CommunityToolkit/WindowsCommunityToolkit that referenced this pull request Feb 10, 2021
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->

## Fixes #3259
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->


<!-- Add a brief overview here of the feature/bug & fix. -->

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

<!-- - Bugfix -->
Feature
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
Sample app changes
<!-- - Other... Please describe: -->


## What is the current behavior?
There is no ribbon or ribbon-like control for UWP. The current solution is to put CommandBars inside of a Pivot.

## What is the new behavior?
Adds a TabbedCommandBar, which internally is almost identical to the current solutions, but provides a much friendlier developer experience.


## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: MicrosoftDocs/WindowsCommunityToolkitDocs#405
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
    - [x] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [x] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->


## Other information
I forgot to do my work on a feature branch, so this PR is basically a duplicate of #3551, with a little bit of cleanup.
@yoshiask
Copy link
Contributor Author

Does anyone know what's going on with the docs.toc.md conflict?

@Kyaa-dost
Copy link
Contributor

@yoshiask taking a look.

@Kyaa-dost Kyaa-dost mentioned this pull request Feb 12, 2021
5 tasks
@Kyaa-dost
Copy link
Contributor

@yoshiask I can't seem to find anything that could be causing this issue. Probably an internal issue with the build.

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yoshiask !! Great work 🚀

@Kyaa-dost Kyaa-dost mentioned this pull request Mar 3, 2021
5 tasks
@opbld33
Copy link

opbld33 commented Mar 5, 2021

Docs Build status updates of commit b9b0b35:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Mar 5, 2021

Docs Build status updates of commit b9b0b35:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@michael-hawker
Copy link
Collaborator

@Kyaa-dost mind reconciling the TOC again? Thanks!

@michael-hawker
Copy link
Collaborator

TODO: Swap out image with a static one

@opbld30
Copy link

opbld30 commented Mar 5, 2021

Docs Build status updates of commit a2e64c3:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ⚠️Warning View Details
docs/resources/images/Controls/TabbedCommandBar.gif ✅Succeeded View
docs/toc.md ✅Succeeded View

docs/controls/TabbedCommandBar.md

  • Line 226, Column 251: [Warning-insecure-link] Link 'http://aka.ms/uwptoolkitapp' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Mar 5, 2021

Docs Build status updates of commit 1f71dbc:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ⚠️Warning View Details
docs/resources/images/Controls/TabbedCommandBar.gif ✅Succeeded View

docs/controls/TabbedCommandBar.md

  • Line 226, Column 251: [Warning-insecure-link] Link 'http://aka.ms/uwptoolkitapp' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@yoshiask yoshiask requested a review from michael-hawker March 6, 2021 00:58
@opbld32
Copy link

opbld32 commented Mar 6, 2021

Docs Build status updates of commit fa67ea4:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ⚠️Warning View Details
docs/resources/images/Controls/TabbedCommandBar.gif ✅Succeeded View
docs/resources/images/Controls/TabbedCommandBar.png ✅Succeeded View

docs/controls/TabbedCommandBar.md

  • Line 224, Column 251: [Warning-insecure-link] Link 'http://aka.ms/uwptoolkitapp' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@michael-hawker
Copy link
Collaborator

@yoshiask think you can fix the Markdown lint issue and swap out the image for a static one? Thanks

@yoshiask
Copy link
Contributor Author

yoshiask commented Mar 8, 2021

@yoshiask think you can fix the Markdown lint issue and swap out the image for a static one? Thanks

@michael-hawker Fixing the lint issue right now, and the image is already static.

Use `https` for `aka.ms` link
@opbld30
Copy link

opbld30 commented Mar 8, 2021

Docs Build status updates of commit fdd0679:

✅ Validation status: passed

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ✅Succeeded View
docs/resources/images/Controls/TabbedCommandBar.gif ✅Succeeded View
docs/resources/images/Controls/TabbedCommandBar.png ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Mar 8, 2021

Docs Build status updates of commit d6eefb4:

✅ Validation status: passed

File Status Preview URL Details
docs/controls/TabbedCommandBar.md ✅Succeeded View
docs/resources/images/Controls/TabbedCommandBar.gif ✅Succeeded View
docs/resources/images/Controls/TabbedCommandBar.png ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Collaborator

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshiask thanks! Missed the commit where you did the switch, but the GIF wasn't git-removed so looks like while the doc is referencing the PNG now the GIF and PNG are both in the PR.

Mind just flattening everything down into a single commit and force-pushing back here on top of the latest master branch? Thanks!

@yoshiask
Copy link
Contributor Author

yoshiask commented Mar 8, 2021

Mind just flattening everything down into a single commit and force-pushing back here on top of the latest master branch? Thanks!

I'm not sure how to do that 😅
Isn't there a dropdown on the "Merge" button that gives the option to squash before merging?

@michael-hawker
Copy link
Collaborator

@yoshiask there is; we can try that, except the gif still needs to be removed.

@michael-hawker michael-hawker added this to the 7.0 milestone Mar 8, 2021
@michael-hawker michael-hawker mentioned this pull request Mar 9, 2021
5 tasks
@michael-hawker
Copy link
Collaborator

Did a rebase and remove in #465 so will close this. Thanks @yoshiask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants