Skip to content

File name mismatch when using the Extract option #26 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

yeheshuah
Copy link
Contributor

@yeheshuah yeheshuah commented Oct 13, 2024

Description

Fixed file name (by adding the date) and a bit of refactoring.

Motivation and Context

File name mismatch when using the Extract option #26

How Has This Been Tested?

Tried to run command below.

python torcrawl.py -v -u https://pikvm.org -e -y t -c -d 2 -p 5

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

@MikeMeliz MikeMeliz linked an issue Oct 23, 2024 that may be closed by this pull request
@MikeMeliz MikeMeliz self-requested a review October 23, 2024 17:39
Copy link
Owner

@MikeMeliz MikeMeliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works as expected on #26 issue's example:
python3 torcrawl.py -v -u http://www.github.com/ -c -d 2 -p 0 -e -w

Result:

@MikeMeliz ➜ /workspaces/TorCrawl.py (master) $ python3 torcrawl.py -v -u http://www.github.com/ -c -d 2 -p 0 -e -w
## Folder created: www.github.com
## Your IP: x.x.x.x
## URL: http://www.github.com/
## Crawler started from http://www.github.com/ with 2 depth crawl, and 0 second(s) delay.
## Step 1 completed with: 55 result(s)
## Step 2 completed with: 993 result(s)
## File created on /workspaces/TorCrawl.py/www.github.com/20241023_links.txt
# File created on: /workspaces/TorCrawl.py/www.github.com/code-search
# File created on: /workspaces/TorCrawl.py/www.github.com/issues
# File created on: /workspaces/TorCrawl.py/www.github.com/forks`
...

@MikeMeliz MikeMeliz merged commit c3df939 into MikeMeliz:master Oct 23, 2024
1 check passed
@MikeMeliz
Copy link
Owner

Thank you for taking the time to fix it @yeheshuah !

@MikeMeliz MikeMeliz added the bug label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File name mismatch when using the Extract option
2 participants