Skip to content

fix: πŸ› should focus editor when clicking todo list #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025

Conversation

Saul-Mirone
Copy link
Member

βœ… Closes: #1917

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Should focus the editor when clicking todo list.

How did you test this change?

E2E

Copy link

vercel bot commented May 31, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
milkdown-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 31, 2025 0:52am

@Saul-Mirone Saul-Mirone marked this pull request as ready for review May 31, 2025 12:51
Copy link

changeset-bot bot commented May 31, 2025

⚠️ No Changeset found

Latest commit: 025e51e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Saul-Mirone Saul-Mirone enabled auto-merge May 31, 2025 12:51
@Saul-Mirone Saul-Mirone added this pull request to the merge queue May 31, 2025
Merged via the queue into main with commit 36ba08a May 31, 2025
13 checks passed
@Saul-Mirone Saul-Mirone deleted the should-focus-when-clicking-todo branch May 31, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] EditorView focus lost on click in ToDo list checkbox
1 participant