Allow #[serde(...)] attributes without deriving De/Serialize
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModProg
requested changes
Jun 20, 2025
daxpedda
commented
Jun 20, 2025
| @@ -5,7 +5,12 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| <!-- ## [Unreleased] --> | |||
There was a problem hiding this comment.
Am I doing the right thing here? Or should I leave something specific in place that cargo-release requires?
There was a problem hiding this comment.
No that is exactly what I use for it 👍 (though at some point I should probably adjust the regex to be less whitespace sensitive :D
ModProg
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the limitation of not being able to use
#[serde(...)]attributes when not derivingDe/Serializewith#[derive_where(...)].Cc @fjarri.
Resolves #122.