-
Notifications
You must be signed in to change notification settings - Fork 1
Large int bug #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large int bug #238
Conversation
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 26 30 +4
Lines 1522 1775 +253
==========================================
+ Hits 1522 1775 +253
Continue to review full report at Codecov.
|
@kwabenantim I'm not expecting you to review the code, but let me know if this solves the issue, if it does I'll release this version. |
There was an issue where in some environments (but not all) large numbers such as 8.034023767017109e+27 whch were ints would be printed as an the int 8034023767017108950029959168 and then the C++ compiler would complain as that's more than the maximum int value. This has been fixed by only printing ints as ints if they are MIN_INT < number < MAX_INT else we print them as a float (and we get the sceintific notation). |
Description
Fixed an issue with printing large ints
Motivation and Context
There was an issue where in some environments (but not all) large numbers such as
8.034023767017109e+27
whch were ints would be printed as an the int8034023767017108950029959168
and then the C++ compiler would complain as that's more than the maximum int value. This has been fixed by only printing ints as ints if they are MIN_INT < number < MAX_INT else we print them as a float (and we get the sceintific notation).Types of changes
Documentation checklist
Testing