Skip to content
This repository was archived by the owner on Feb 9, 2022. It is now read-only.

Fix old unzip dep #45

Merged
merged 8 commits into from
Nov 8, 2018
Merged

Conversation

reinaldorauch
Copy link
Contributor

Updated FileSystem#extractZip to not depend on unzip so it can be removed from package deps to allow dependant packages to be used with node 11.0.0 and forwards.

Copy link
Contributor

@Fatme Fatme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯

@reinaldorauch
Copy link
Contributor Author

reinaldorauch commented Nov 7, 2018

@Fatme fixed your noted issues

@Fatme
Copy link
Contributor

Fatme commented Nov 8, 2018

@reinaldorauch ,

Thank you for the contribution!

@Fatme Fatme merged commit d69a3a0 into NativeScript:master Nov 8, 2018
@reinaldorauch reinaldorauch deleted the fix-old-unzip-dep branch November 8, 2018 16:58
@radeva
Copy link
Contributor

radeva commented Nov 19, 2018

Hi @reinaldorauch ,

Congratulations on being one of the winners in the {N} First-time contributors contest!

You can claim your prize by contacting us at nativescriptwinners[at]progress.com not later than Nov 30th 2018 . Make sure you send us the following info: 
👉Your full name 
👉Your email 
👉Your country or residence 

Best regards,
The NativeScript Team

@reinaldorauch
Copy link
Contributor Author

@radeva just sended the email, thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants