Skip to content

fix: patch module based on reports from iniBuilds A350 launch #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

SkySails
Copy link
Contributor

@SkySails SkySails commented Feb 27, 2025

This pull request includes several changes across different files to improve error handling, add new enum variants, and enhance initialization logic. The most important changes are grouped by theme below.

Error Handling Improvements:

Enum Enhancements:

Initialization and Update Logic:

Utility Function Improvements:

SIMDEV-350

Base automatically changed from v1-workflow-fixes to v1 February 27, 2025 14:11
Copy link
Contributor

@professoralex13 professoralex13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of unwrap_or_default in all these cases, could we instead just have graceful failure without a panic using Result? If all these values default to zero in failure cases, surely that makes it harder for the user application to tell what is invalid data and what is actually just (0, 0) coordinates? same goes for the other unwrap_or_default I didn't highlight

@SkySails
Copy link
Contributor Author

AFAIK this approach was taken in order not to break iniBuilds current implementation, which we assume is not ready to handle a change in behavior like that. Let's discuss it!

@ZigTag ZigTag merged commit 18920c6 into v1 Feb 28, 2025
4 checks passed
@ZigTag ZigTag deleted the v1-inibuilds-day1 branch February 28, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants