Skip to content

Fixes certificate renewal #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2021
Merged

Fixes certificate renewal #1286

merged 3 commits into from
Aug 7, 2021

Conversation

chaptergy
Copy link
Collaborator

This will fix the certificate renewal in some cases:

  • Automatic renewal using DNS challenges used to always fail due to the authenticator being overwritten globally
  • Automatic renewal using the HTTP challenge used to fail if the domain was not used in any host.

This PR removes the global authenticator being set, since it is always set certificate specific as well, and adds the letsencrypt challenge functionality to the default host (using any of the congratulations site, 404 page, redirect or custom page)

Should fix #1282, probably fixes #1220, fixes #1031, should fix #1018 and fixes #860

@chaptergy chaptergy force-pushed the fixes-certificate-renewal branch from 0a99e7e to d346911 Compare August 4, 2021 12:08
@chaptergy
Copy link
Collaborator Author

The failing check does not seem related to the content of the PR.

@jc21
Copy link
Member

jc21 commented Aug 4, 2021

This is an automated message from CI:

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1286

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21
Copy link
Member

jc21 commented Aug 4, 2021

This is an automated message from CI:

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1286

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21
Copy link
Member

jc21 commented Aug 6, 2021

This is an automated message from CI:

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1286

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants