Added support to download Let's Encrypt Certificate

[ssrahul96]

Covered Issue #404

[jc21]

This is an automated message from CI:

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[jc21]

This is an automated message from CI:

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[jc21]

This is an automated message from CI:

Docker Image for build 4 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[jc21]

This is an automated message from CI:

Docker Image for build 5 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[ssrahul96]

handled by using certificate.provider

[jc21]

This is an automated message from CI:

Docker Image for build 6 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[jc21]

This is an automated message from CI:

Docker Image for build 7 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[ssrahul96]

@jc21 , can it be merged?? or any other additional changes required??

[jc21]

This is an automated message from CI:

Docker Image for build 8 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[jc21]

Hmm no it doesn't seem to be ready. Have you tested this yourself?

I just tried it for some LE certs, take a look:

You'll notice that the files are not the actual files, they are symlinks. So your code to zip stuff up needs to dereference (or follow?) the symlinks somehow to include the actual files instead.

[jc21]

This is an automated message from CI:

Docker Image for build 9 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[ssrahul96]

Hmm no it doesn't seem to be ready. Have you tested this yourself?

I just tried it for some LE certs, take a look:

You'll notice that the files are not the actual files, they are symlinks. So your code to zip stuff up needs to dereference (or follow?) the symlinks somehow to include the actual files instead.

Handled with the actual path

[jc21]

Well yes it's an improvement, but you only have 1 certificate in that folder. The majority of users who have certs renewing over time will have all the old ones too. In my example above I have 21 certificates (84 files). Your script will zip them all up instead of the most current one.

This is why I think dereferencing those symlinks is a better idea than grabbing everything from archive.

[jc21]

This is an automated message from CI:

Docker Image for build 10 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[jc21]

This is an automated message from CI:

Docker Image for build 11 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1343

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[ssrahul96]

Well yes it's an improvement, but you only have 1 certificate in that folder. The majority of users who have certs renewing over time will have all the old ones too. In my example above I have 21 certificates (84 files). Your script will zip them all up instead of the most current one.

This is why I think dereferencing those symlinks is a better idea than grabbing everything from archive.

deferenced the symlinks and zipped the certs using realpathSync

[jc21]

Working beautifully thanks :)