Skip to content

merge master #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Feb 24, 2021
Merged

merge master #32

merged 31 commits into from
Feb 24, 2021

Conversation

Nic-Ma
Copy link
Owner

@Nic-Ma Nic-Ma commented Feb 24, 2021

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli and others added 30 commits February 2, 2021 09:32
@wyli
1534 type hints numpy 1 20 (#1536)
c415509 
* numpy dtype alias

Signed-off-by: Wenqi Li <[email protected]>

* is_tensor => isinstance

Signed-off-by: Wenqi Li <[email protected]>

* type of dtype

Signed-off-by: Wenqi Li <[email protected]>

* relaxes some typing constraints

Signed-off-by: Wenqi Li <[email protected]>

* fixes unit tests

Signed-off-by: Wenqi Li <[email protected]>

* update based on the comments

Signed-off-by: Wenqi Li <[email protected]>

* fixes docstring typos

Signed-off-by: Wenqi Li <[email protected]>
@rijobro
1512 rand_gaussian_noised with multiple keys (#1530)
5e8d2a9 
* rand_gaussian_noised with multiple keys

Signed-off-by: Richard Brown <[email protected]>

* update key names

Signed-off-by: Richard Brown <[email protected]>

* clear list of noise before randomising

Signed-off-by: Richard Brown <[email protected]>

* add type

Signed-off-by: Richard Brown <[email protected]>

* bug fix

Signed-off-by: Richard Brown <[email protected]>

* use ensure_tuple_rep

Signed-off-by: Richard Brown <[email protected]>
@Nic-Ma
1478 Fix TorchScript issue in AHNet with PyTorch 1.5 (#1538)
97ff1e0 
* [DLMED] fix TorchScript issue in AHNet

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add test cases

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix torchscript issue in PyTorch 1.5

Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma @monai-bot
1533 Fix distributed data parallel issue in ClassificationSaver (#1535)
26581a0 
* [DLMED] fix distirbuted data parallel issue in ClassificationSaver

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] fix min test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add @SkipIfBeforePyTorchVersion((1, 7))

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix typo

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

Co-authored-by: monai-bot <[email protected]>
@Nic-Ma @wyli
1539 Add warning message to SmartCache (#1540)
fbab554 
* [DLMED] update SmartCacheDataset docs and warning

Signed-off-by: Nic Ma <[email protected]>

* isAlive => is_alive

Signed-off-by: Wenqi Li <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
@Nic-Ma
1531 Fix evenly divisible issue in the AUC metric (#1532)
f7565bf 
* [DLMED] fix evenly divisible issue in AUC metric

Signed-off-by: Nic Ma <[email protected]>
@kate-sann5100
1525 add MultiScaleLoss (#1544)
2021f24
@Nic-Ma @monai-bot @wyli
1542 Add RandLambdad transform (#1546)
bcdee8c 
* [DLMED] add RandLambdad transform

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add doc-strings

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix typo

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] change to rtol=1e-05

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* fixes seeds

Signed-off-by: Wenqi Li <[email protected]>

Co-authored-by: monai-bot <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
@Nic-Ma
1555 Fix typo in SegResNet doc-string (#1563)
5a237c6 
* [DLMED] fix typo in the doc-string of SegResNet

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to Yiheng's comments

Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] Enhance doc-string of transforms (#1562)
aab702a 
Signed-off-by: Nic Ma <[email protected]>
@wyli
extention -> extension (#1565)
866d53d 
Signed-off-by: Wenqi Li <[email protected]>
@Nic-Ma @monai-bot
1570 Fix distributed issue in ClassificationSaver (#1571)
8d70890 
* [DLMED] fix classification saver issue

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] enhance distributed tests

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

Co-authored-by: monai-bot <[email protected]>
@Nic-Ma
1556 Optimize the numpy computation for spatial axes (#1572)
910b1d4 
* [DLMED] Enhance doc-string of transforms

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] optimize the numpy computation

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8 issue

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma @monai-bot
Add base class for TensorBoard handlers (#1573)
af1ffd6 
* [DLMED] add base class for TensorBoard handlers

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] enhance integration test with TensorBoard writer

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] add close method

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] Enhance MetricsSaver doc-strings

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
@kate-sann5100 @wyli
1559 add DVF2DDF (#1566)
3bdf0c8 
* 1559 add DVF2DDF

Signed-off-by: kate-sann5100 <[email protected]>

* 1559 add gradient test

Signed-off-by: kate-sann5100 <[email protected]>

* update docs; test cases

Signed-off-by: Wenqi Li <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
@yiheng-wang-nv
Modify dynunet forward function (#1596)
3f16c21 
Signed-off-by: Yiheng Wang <[email protected]>
@YuanTingHsieh
Add deepgrow dataset (#1581)
1b170d8 
* Add deepgrow dataset

Signed-off-by: YuanTingHsieh <[email protected]>

* Fix CI/CD issue

Signed-off-by: YuanTingHsieh <[email protected]>

* Fix issues based on review

Signed-off-by: YuanTingHsieh <[email protected]>
@Nic-Ma @monai-bot
1568 Enhance tests to use self random state (#1599)
181f633 
* [DLMED] change tests to use self random state

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] fix CI tests

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
@wyli
Revert "1568 Enhance tests to use self random state (#1599)" (#1607)
19a9f05 
This reverts commit 181f633.

Signed-off-by: Wenqi Li <[email protected]>
@adamaji
Update minimum ITK version to 5.0 (#1609)
5b72d05 
Signed-off-by: Adam Aji <[email protected]>
@adamaji
Throw warning when reading NRRD05 files to upgrade to ITK >= 5.2 (#1602)
e9bf574 
Signed-off-by: Adam Aji <[email protected]>
@YuanTingHsieh
Add deepgrow interaction (#1582)
5dffc11 
* Add deepgrow interaction

Signed-off-by: YuanTingHsieh <[email protected]>

* Fix review comments

Signed-off-by: Sachidanand Alle <[email protected]>
@YuanTingHsieh
Add deepgrow training transforms (#1579)
46cc0e5 
* Add DeepGrow 2D/3D transforms

Signed-off-by: YuanTingHsieh <[email protected]>

* Fix docstrings

Signed-off-by: YuanTingHsieh <[email protected]>

* Remove inference transform for smaller PR

Signed-off-by: YuanTingHsieh <[email protected]>

* Remove unused imports

Signed-off-by: YuanTingHsieh <[email protected]>

* Fix review comments

Signed-off-by: YuanTingHsieh <[email protected]>

* Fix review comments

Signed-off-by: YuanTingHsieh <[email protected]>
@Nic-Ma
1575 Add SaveImage and SaveImaged transforms (#1612)
a664506 
* [DLMED] add SaveImage and SaveImaged transforms

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix typo

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix flake8 issues

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix CI tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add ignore

Signed-off-by: Nic Ma <[email protected]>
@wyli
1545 upgrade base image to pytorch 20.12 (#1613)
75b78cd 
* test new image

Signed-off-by: Wenqi Li <[email protected]>

* temp no cron

Signed-off-by: Wenqi Li <[email protected]>

* fixes unit tests

Signed-off-by: Wenqi Li <[email protected]>

* adds base docker test

Signed-off-by: Wenqi Li <[email protected]>

* undo temp tests

Signed-off-by: Wenqi Li <[email protected]>
@Nic-Ma @monai-bot
1578 Add support to resume previous best metrics in CheckpointSaver (#…
cb5f899 
…1608)

* [DLMED] add support to resume metrics in CheckpointSaver

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] fix doc-string

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
@wyli
1618 Fixes Dockerfile (#1619)
d22c112 
* update dockerfile

Signed-off-by: Wenqi Li <[email protected]>

* temp tests

Signed-off-by: Wenqi Li <[email protected]>

* Revert "temp tests"

This reverts commit 9cbfaa9.

Signed-off-by: Wenqi Li <[email protected]>
@rijobro
determine if is_quick without using decorator (#1620)
3e7f53f 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
make random inverse affine matrix (#1621)
a894adc 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
Compose len (#1622)
6bdc8c6 
* Compose len

Signed-off-by: Richard Brown <[email protected]>

* Compose.flatten()

Signed-off-by: Richard Brown <[email protected]>
@Nic-Ma Nic-Ma merged commit cd16a13 into Nic-Ma:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Nic-Ma @wyli @rijobro @kate-sann5100 @yiheng-wang-nv @YuanTingHsieh @adamaji