Skip to content

Fix prettier linting issues from #563 #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

onnimonni
Copy link
Contributor

@onnimonni onnimonni commented Oct 30, 2024

This is continuation for #567 where I fixed the changed types so that the builds work again after they broke from merging #563.

Before these changes:

$ yarn test:prettier
yarn run v1.22.22
$ prettier '**/*.{js,jsx,ts,tsx}' --check
Checking formatting...
[warn] packages/react-notion-x/src/third-party/collection-card.tsx
[warn] Code style issues found in the above file. Forgot to run Prettier?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

So I then ran: yarn test:prettier --write

And the result after these changes:

$ yarn test:prettier
yarn run v1.22.22
$ prettier '**/*.{js,jsx,ts,tsx}' --check
Checking formatting...
All matched files use Prettier code style!
✨  Done in 2.72s.

This should fix the failing test:prettier check.

Sorry that I didn't realize to combine them in the first place 🙇.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ✅ Ready (Inspect) Visit Preview Oct 30, 2024 8:39pm
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Oct 30, 2024 8:39pm

…es-from-card-cover-position

* upstream/master:
  Add missing new attribute 'card_cover_position' to BasePageBlock to fix ts build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants