Add dns resolver #117
Merged
Add dns resolver #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaydin-tr
suggested changes
Jun 25, 2022
index.ts
Outdated
| @@ -21,13 +22,20 @@ interface IPreFetchedResource { | |||
| data: string; | |||
| } | |||
|
|
|||
| const metaTag = (doc: cheerio.Root, type: string, attr: string) => { | |||
| function throwOnLoopback(address: string) { | |||
| if (address === "localhost" || address === "127.0.0.1") { | |||
There was a problem hiding this comment.
The loopback address doesn't always have to be "localhost" or "127.0.0.1", we may need to check other reserved local ips, I think it makes more sense to use regex for this. e.g
new RegExp(
"^" +
"(?:(?:10|127)(?:\\.\\d{1,3}){3})" +
"|" +
"(?:(?:169\\.254|192\\.168|192\\.0)(?:\\.\\d{1,3}){2})" +
"|" +
"(?:172\\.(?:1[6-9]|2\\d|3[0-1])(?:\\.\\d{1,3}){2})" +
"$",
"i"
)
if you can find a more comprehensive regex it will be nice too
There was a problem hiding this comment.
I'll just use this regex for now
|
released under 1.1.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115
@AbdurrahmanA would you mind taking a look and making sure the implementation is correct?