Skip to content

Commit 6344bfa

Browse files
authored
[php-flight] fix: use static PHPUnit assertions (#21253)
Static analysis tools such as PHPStan report errors when dynamic calls are used for static methods. ``` ERROR Dynamic call to static method PHPUnit\Framework\Assert::assertEquals(). ``` According to the source code of PHPUnit (https://github.com/sebastianbergmann/phpunit/blob/9.5.0/src/Framework/Assert.php) the function is indeed static. ```php public static function assertTrue($condition, string $message = ''): void ``` This change updates to PHP Flight test template `register_routes_test.mustache` to use static calls for PHPUnit assertions.
1 parent 66e8c93 commit 6344bfa

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

modules/openapi-generator/src/main/resources/php-flight/register_routes_test.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
2626
{{/operations}}
2727
};
2828
\{{invokerPackage}}\RegisterRoutes::registerRoutes($handler);
29-
$this->assertTrue(true);
29+
self::assertTrue(true);
3030
}
3131
{{/apis}}
3232
{{#models}}
@@ -41,7 +41,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
4141
{{/-first}}
4242
{{/enumVars}}
4343
{{/allowableValues}}
44-
$this->assertEquals(
44+
self::assertEquals(
4545
parseParam($value, '\\{{escapedModelPackage}}\\{{classname}}'),
4646
\{{modelPackage}}\{{classname}}::{{#allowableValues}}{{#enumVars}}{{#-first}}{{{name}}}{{/-first}}{{/enumVars}}{{/allowableValues}}
4747
);

samples/server/petstore/php-flight/Test/RegisterRoutesTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function addPet(\OpenAPIServer\Model\Pet $pet): \OpenAPIServer\Model\Pet|
2929
}
3030
};
3131
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
32-
$this->assertTrue(true);
32+
self::assertTrue(true);
3333
}
3434
public function testRegisterRoutesAbstractStoreApi(): void
3535
{
@@ -39,7 +39,7 @@ public function deleteOrder(string $orderId): void
3939
}
4040
};
4141
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
42-
$this->assertTrue(true);
42+
self::assertTrue(true);
4343
}
4444
public function testRegisterRoutesAbstractUserApi(): void
4545
{
@@ -49,28 +49,28 @@ public function createUser(\OpenAPIServer\Model\User $user): void
4949
}
5050
};
5151
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
52-
$this->assertTrue(true);
52+
self::assertTrue(true);
5353
}
5454
public function testParseParamsEnumFindPetsByStatusStatusParameterInner(): void
5555
{
5656
$value = 'available';
57-
$this->assertEquals(
57+
self::assertEquals(
5858
parseParam($value, '\\OpenAPIServer\\Model\\FindPetsByStatusStatusParameterInner'),
5959
\OpenAPIServer\Model\FindPetsByStatusStatusParameterInner::AVAILABLE
6060
);
6161
}
6262
public function testParseParamsEnumOrderStatus(): void
6363
{
6464
$value = 'placed';
65-
$this->assertEquals(
65+
self::assertEquals(
6666
parseParam($value, '\\OpenAPIServer\\Model\\OrderStatus'),
6767
\OpenAPIServer\Model\OrderStatus::PLACED
6868
);
6969
}
7070
public function testParseParamsEnumPetStatus(): void
7171
{
7272
$value = 'available';
73-
$this->assertEquals(
73+
self::assertEquals(
7474
parseParam($value, '\\OpenAPIServer\\Model\\PetStatus'),
7575
\OpenAPIServer\Model\PetStatus::AVAILABLE
7676
);

0 commit comments

Comments
 (0)