[php-flight] fix: use static PHPUnit assertions

[jrenggli]

Hi

Static analysis tools such as PHPStan report errors when dynamic calls are used for static methods.

ERROR Dynamic call to static method PHPUnit\Framework\Assert::assertEquals().

According to the source code of PHPUnit
(https://github.com/sebastianbergmann/phpunit/blob/9.5.0/src/Framework/Assert.php) the function is indeed static.

public static function assertTrue($condition, string $message = ''): void

This change updates to PHP Flight test template register_routes_test.mustache to use static calls for PHPUnit assertions.

@jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon: Thanks for having a look at this PR. Please inform me if there's anything I'd have to improve to get this merged.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[wing328]

thanks for the PR which has been merged