-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[JAVA][FEIGN] Removing hardcoded HTTP Client which is causing performance issues #21085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA][FEIGN] Removing hardcoded HTTP Client which is causing performance issues #21085
Conversation
Fixing performance issues
@sushma3690 thanks for the PR 🙏
Can you please share the URL to the comment? I reviewed the PR again but couldn't find it. |
* Implement unit tests for feign client Implement tests Migrate to junit 5 * Default feign client does not support PATCH verb Default feign client does not support PATCH verb * Remove test for GET endpoint with request body * Configure junit in gradle build * Configure logback for unit tests * Add missing dependencies to sbt * Fix gradle dependency * Add logback to gradle unit test * Regenerate samples * Make junit test classes package private * Make junit test classes package private * Update samples * Organize imports * Organize imports
thanks. i missed that cc @hugo-ma-alves (author of the PR in question) |
@wing328 I will generate the samples and update the PR |
please update the samples (step 3 in pr checklist) to fix the CI failure. |
@wing328 I have updated the samples, Can you please do the needful to trigger the workflows. Thank you |
++ Adding Java committee @wing328 / @bbdouglas / @sreeshas / @jfiala / @lukoyanov / @cbornet / @jeff9finger / @karismann / @Zomzog / @lwlee2608 / @martin-mfg I have updated the samples, Can someone please do the needful to trigger the workflows. Thank you |
let me know if you need help fixing it |
looking into it. will get back in few minutes |
![]()
![]() |
@wing328 All checks passed, can you please approve the PR so that we can merge it. Thank you ! |
just merged it. thanks for the contribution |
This has introduced a backwards incompatible change: #21187. |
@lesteenman thanks for reporting the issue @sushma3690 can you please review the issue when you've time? |
Fixing performance issues due to Hardcoded HTTP client
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)