adjust jersey2/jersey3 templates #21171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make jersey2 and jersey3 templates as similar to each other as possible. As requested by @wing328.
Jersey 3 doesn't work with useJakartaEe=false. And Jersey 2 doesn't work with useJakartaEe=true.
Jersey 2 is hard-wired to the javax namespace. See e.g. the Jersey 2 class ClientConfig - it implements
javax.ws.rs.core.Configurable<ClientConfig>
andjavax.ws.rs.core.Configuration
, but nothing from the jakarta namespace. And vice versa for Jersey 3. You can verify the problem by generating something with library=jersey2 and useJakartaEe=true - the output won't compile due to incompatible types.It's still beneficial to make the Jersey 2 and Jersey 3 templates as similar as possible, for maintainability. I also added a warning when using useJakartaEe=true with Jersey 2.
Now the only remaining differences between Jersey 2 and Jersey 3 are dependency versions:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)