Kotlin Misk Add Extra Parameters #21271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
May 13, 2025
| import misk.web.interceptors.LogRequestResponse | ||
| import misk.web.mediatype.MediaTypes | ||
| import misk.web.mediatype.MediaTypes{{#actionImports}} | ||
| {{{.}}}{{/actionImports}} |
There was a problem hiding this comment.
import misk.web.mediatype.MediaTypes
{{#actionImports}}
{{{.}}}
{{/actionImports}}
please use the above to avoid blank lines
wing328
reviewed
May 13, 2025
| @ResponseContentType({{#produces}}{{{mediaType}}}{{^-last}}, {{/-last}}{{/produces}}){{/hasProduces}} | ||
| @LogRequestResponse(bodySampling = 1.0, errorBodySampling = 1.0) | ||
| @ResponseContentType({{#produces}}{{{mediaType}}}{{^-last}}, {{/-last}}{{/produces}}){{/hasProduces}}{{#actionAnnotations}} | ||
| {{{.}}}{{/actionAnnotations}} |
There was a problem hiding this comment.
@ResponseContentType({{#produces}}{{{mediaType}}}{{^-last}}, {{/-last}}{{/produces}}){{/hasProduces}}
{{#actionAnnotations}}
{{{.}}}
{{/actionAnnotations}}
please put start and end tags in separate lines to avoid blank lines
guiarn
approved these changes
May 13, 2025
bin/configs/kotlin-misk-config.yaml
Outdated
| actionParentClass: "WebAction" | ||
| actionRequestContentType: "@RequestContentType(" | ||
| actionRequestContentTypePrefix: "MediaTypes." |
There was a problem hiding this comment.
Having to add a . to the string might not be obvious, maybe we can move it to the mustache template?
bin/configs/kotlin-misk-config.yaml
Outdated
| import misk.web.interceptors.LogRequestResponse | ||
| actionParentClass: "WebAction" | ||
| actionRequestContentType: "@RequestContentType(" |
There was a problem hiding this comment.
also having to add the ( to the string might lead to people just forgetting to add it. Can it be moved to the template too?
guiarn
approved these changes
May 13, 2025
|
@wing328 Ready to go, I improved the tests quite a bit! |
andrewwilsonnew
force-pushed
the
andrew.wilson/misk6
branch
from
9fc17f8 to
ac7df6e
Compare
|
lgtm. thanks for the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)cc: @guiarn