Skip to content

[php-laravel generator] update $request->bool to $request->boolean #21273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025

Conversation

jglagrimas
Copy link
Contributor

Update the api_controller.mustach

$request->bool is not a laravel function ,
should be $request->boolean()

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

$request->bool is not a laravel function should be $request->boolean()
…st-boolean

Chores : update $request->bool to $request->boolean
@wing328
Copy link
Member

wing328 commented May 13, 2025

can you please follow step 3 to update the samples to address https://github.com/OpenAPITools/openapi-generator/actions/runs/14993742514/job/42123368205?pr=21273?

@jglagrimas
Copy link
Contributor Author

@wing328

do i need to run the script?
i just edited the sample directly.

sorry new to this stuff..

@wing328
Copy link
Member

wing328 commented May 14, 2025

using the script should be easier. of course you can do it manually as well

cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@wing328 wing328 merged commit a0b9ecd into OpenAPITools:master May 14, 2025
27 checks passed
@wing328
Copy link
Member

wing328 commented May 14, 2025

let's give it a try

thanks for the contribution.

@jglagrimas
Copy link
Contributor Author

@wing328

no worries, ill update some stuff in the future as well,
currently using the plugin for our contracts first approach,

@gijs-blanken Thanks again,

@gijs-blanken
Copy link
Contributor

@jglagrimas Oops, my mistake on the ->boolean(). Thanks for fixing it! And great to hear someone else is using the generator 😄

@wing328 wing328 added this to the 7.14.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants