feat (JAVA NATIVE): add support for useSingleRequestParameter to java native client #21331
+64
−30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,7 +106,7 @@ public class {{classname}} { | |
| /** | ||
| * {{summary}} | ||
| * {{notes}} | ||
| * @param apiRequest {@link API{{#lambda.titlecase}}{{operationId}}{{/lambda.titlecase}}Request} | ||
| {{#returnType}} | ||
| * @return {{#asyncNative}}CompletableFuture<{{/asyncNative}}{{returnType}}{{#asyncNative}}>{{/asyncNative}} | ||
| {{/returnType}} | ||
|
|
@@ -127,7 +127,7 @@ public class {{classname}} { | |
| {{#isDeprecated}} | ||
| @Deprecated | ||
| {{/isDeprecated}} | ||
| public {{#returnType}}{{#asyncNative}}CompletableFuture<{{{returnType}}}>{{/asyncNative}}{{^asyncNative}}{{{returnType}}}{{/asyncNative}}{{/returnType}}{{^returnType}}{{#asyncNative}}CompletableFuture<Void>{{/asyncNative}}{{^asyncNative}}void{{/asyncNative}}{{/returnType}} {{operationId}}(API{{#lambda.titlecase}}{{operationId}}{{/lambda.titlecase}}Request apiRequest) throws ApiException { | ||
| {{#allParams}} | ||
| {{>nullable_var_annotations}} | ||
| {{{dataType}}} {{paramName}} = apiRequest.{{paramName}}(); | ||
|
|
@@ -138,7 +138,7 @@ public class {{classname}} { | |
| /** | ||
| * {{summary}} | ||
| * {{notes}} | ||
| * @param apiRequest {@link API{{#lambda.titlecase}}{{operationId}}{{/lambda.titlecase}}Request} | ||
| * @return {{#asyncNative}}CompletableFuture<{{/asyncNative}}ApiResponse<{{returnType}}{{^returnType}}Void{{/returnType}}>{{#asyncNative}}>{{/asyncNative}} | ||
| * @throws ApiException if fails to make API call | ||
| {{#isDeprecated}} | ||
|
|
@@ -152,7 +152,7 @@ public class {{classname}} { | |
| {{#isDeprecated}} | ||
| @Deprecated | ||
| {{/isDeprecated}} | ||
| public {{#asyncNative}}CompletableFuture<{{/asyncNative}}ApiResponse<{{{returnType}}}{{^returnType}}Void{{/returnType}}>{{#asyncNative}}>{{/asyncNative}} {{operationId}}WithHttpInfo(API{{#lambda.titlecase}}{{operationId}}{{/lambda.titlecase}}Request apiRequest) throws ApiException { | ||
|
There was a problem hiding this comment. thanks for the PR why do you need to wrap operationId with titlecase lambda? There was a problem hiding this comment. @wing328 Without it the operationId as part of the parameter class name would be starting with lowercase. For example it would be “APIdeletePetRequest” without it and “APIDeletePetRequest”. The second one is more camel case and Java typical in my opinion. :) There was a problem hiding this comment. so this PR is more like "correcting" the parameter class naming, right? There was a problem hiding this comment. @wing328 I "corrected" the parameter class name, yes but I also enabled the generation for the java native client (see the changes in JavaClientCodegen). Before this PR this part was never generated. |
||
| {{#allParams}} | ||
| {{{dataType}}} {{paramName}} = apiRequest.{{paramName}}(); | ||
| {{/allParams}} | ||
|
|
@@ -574,7 +574,7 @@ public class {{classname}} { | |
| {{#vendorExtensions.x-group-parameters}} | ||
| {{#hasParams}} | ||
|
|
||
| public static final class API{{#lambda.titlecase}}{{operationId}}{{/lambda.titlecase}}Request { | ||
| {{#requiredParams}} | ||
| {{>nullable_var_annotations}} | ||
| private {{{dataType}}} {{paramName}}; // {{description}} (required) | ||
|
|
@@ -584,7 +584,7 @@ public class {{classname}} { | |
| private {{{dataType}}} {{paramName}}; // {{description}} (optional{{^isContainer}}{{#defaultValue}}, default to {{.}}{{/defaultValue}}{{/isContainer}}) | ||
| {{/optionalParams}} | ||
|
|
||
| private API{{#lambda.titlecase}}{{operationId}}{{/lambda.titlecase}}Request(Builder builder) { | ||
| {{#requiredParams}} | ||
| this.{{paramName}} = builder.{{paramName}}; | ||
| {{/requiredParams}} | ||
|
|
@@ -616,8 +616,8 @@ public class {{classname}} { | |
| return this; | ||
| } | ||
| {{/allParams}} | ||
| public API{{#lambda.titlecase}}{{operationId}}{{/lambda.titlecase}}Request build() { | ||
| return new API{{#lambda.titlecase}}{{operationId}}{{/lambda.titlecase}}Request(this); | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1501,11 +1501,11 @@ private HttpRequest.Builder testEnumParametersRequestBuilder(@javax.annotation.N | |
| /** | ||
| * Fake endpoint to test group parameters (optional) | ||
| * Fake endpoint to test group parameters (optional) | ||
| * @param apiRequest {@link APITestGroupParametersRequest} | ||
| * @return CompletableFuture<Void> | ||
| * @throws ApiException if fails to make API call | ||
| */ | ||
| public CompletableFuture<Void> testGroupParameters(APITestGroupParametersRequest apiRequest) throws ApiException { | ||
|
There was a problem hiding this comment. @Nicklas2751 fyi. i saw this change, which may become a breaking change for other users for the time, we will consider this as a bug fix to correct the naming and see if there's a need to provide a fallback later (one way to fallback is to use customized templates) |
||
| @javax.annotation.Nonnull | ||
| Integer requiredStringGroup = apiRequest.requiredStringGroup(); | ||
| @javax.annotation.Nonnull | ||
|
|
@@ -1524,11 +1524,11 @@ public CompletableFuture<Void> testGroupParameters(APItestGroupParametersRequest | |
| /** | ||
| * Fake endpoint to test group parameters (optional) | ||
| * Fake endpoint to test group parameters (optional) | ||
| * @param apiRequest {@link APITestGroupParametersRequest} | ||
| * @return CompletableFuture<ApiResponse<Void>> | ||
| * @throws ApiException if fails to make API call | ||
| */ | ||
| public CompletableFuture<ApiResponse<Void>> testGroupParametersWithHttpInfo(APITestGroupParametersRequest apiRequest) throws ApiException { | ||
| Integer requiredStringGroup = apiRequest.requiredStringGroup(); | ||
| Boolean requiredBooleanGroup = apiRequest.requiredBooleanGroup(); | ||
| Long requiredInt64Group = apiRequest.requiredInt64Group(); | ||
|
|
@@ -1662,7 +1662,7 @@ private HttpRequest.Builder testGroupParametersRequestBuilder(@javax.annotation. | |
| } | ||
|
|
||
|
|
||
| public static final class APITestGroupParametersRequest { | ||
| @javax.annotation.Nonnull | ||
| private Integer requiredStringGroup; // Required String in group parameters (required) | ||
| @javax.annotation.Nonnull | ||
|
|
@@ -1676,7 +1676,7 @@ public static final class APItestGroupParametersRequest { | |
| @javax.annotation.Nullable | ||
| private Long int64Group; // Integer in group parameters (optional) | ||
|
|
||
| private APITestGroupParametersRequest(Builder builder) { | ||
| this.requiredStringGroup = builder.requiredStringGroup; | ||
| this.requiredBooleanGroup = builder.requiredBooleanGroup; | ||
| this.requiredInt64Group = builder.requiredInt64Group; | ||
|
|
@@ -1744,8 +1744,8 @@ public Builder int64Group(@javax.annotation.Nullable Long int64Group) { | |
| this.int64Group = int64Group; | ||
| return this; | ||
| } | ||
| public APITestGroupParametersRequest build() { | ||
| return new APITestGroupParametersRequest(this); | ||
| } | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wing328 This PR enables the generation of the single parameter class for the Java native client. Before this PR, enabling ‘useSingleRequestParameter’ doesn’t changed anything for the Java native client.