Skip to content

fix(python-fastapi): remove 200 fallback code and use default (#12481) #21333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sickinga
Copy link
Contributor

Currently the default code of the Python FastAPI would be 200 when in reality it would be more suitable to keep it empty (or 0), as stated in #12481.

Here is the OpenAPI.yaml that was used as input:
https://github.com/OAI/OpenAPI-Specification/blob/aa91a19c43f8a12c02efa42d64794e396473f3b1/examples/v3.0/petstore-expanded.yaml#L51

Here is what it currently produces:

    responses={
        200: {"model": Pet, "description": "pet response"},
        200: {"model": Error, "description": "unexpected error"},
    },

this is what it now produces:

    responses={
        200: {"model": Pet, "description": "pet response"},
        "default": {"model": Error, "description": "unexpected error"},
    },

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cbornet, @tomplus, @krjakbrjak, @fa0311, @multani

@sickinga
Copy link
Contributor Author

@wing328 should be ready for review, right? :)

@renatomameli
Copy link
Contributor

Thank you @sickinga. We really rely on this fix and it would be great if we can get this in an upcoming release! @wing328

@wing328 wing328 merged commit 49cadfe into OpenAPITools:master Jun 3, 2025
16 checks passed
@wing328
Copy link
Member

wing328 commented Jun 3, 2025

PR merged. Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants