-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Abstract PHP support of "original" for variableNamingConvention #21336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract PHP support of "original" for variableNamingConvention #21336
Conversation
…vel help file to include 'off' as a valid value
…etailed descriptions in documentation
@wing328 if you know a reviewer :) |
thanks for the PR what about naming the option as |
…n AbstractPhpCodegen
Sure, if it is used in other places, why not, did the change and updated the PR |
@wing328 once more? 😶🌫️ |
Sorry for the ping, but this one is simple and blocked, asking for review: @renepardon @gijs-blanken @wing328 |
…nd pull_request events
thanks for the PR. let's give it a try |
Resolving #21334: Added the support for "original" value for "variableNamingConvention" option. When used it will not modify the names
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)