[Java] Fix content for enum in MultiPart (#19973) #21373
Conversation
|
please follow step 3 to update samples so that CI can verify the change |
jarryDk
changed the title
| @@ -0,0 +1,7 @@ | |||
| generatorName: java | |||
| outputDir: samples/client/others/java/restclient-enum-in-multipart | |||
There was a problem hiding this comment.
please add this new folder to the github workflow so that ci will test it moving forward
There was a problem hiding this comment.
New folder added to https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-java-client-jdk17.yaml as Spring needs Java 17
|
can you please review the CI failure when you've time? |
|
Had a look at For now my PR only update |
|
do you need help updating the samples to fix https://github.com/OpenAPITools/openapi-generator/actions/runs/15577774453/job/44161740116?pr=21373 ? |
|
@wing328 - It should be ok now. I have update the samples with where i previous used |
| object ApiResponse { | ||
| implicit val encoderApiResponse: Encoder[ApiResponse] = deriveEncoder[ApiResponse].mapJson(_.dropNullValues) | ||
| implicit val decoderApiResponse: Decoder[ApiResponse] = deriveDecoder[ApiResponse] | ||
| } |
There was a problem hiding this comment.
there shouldn't be change to scala samples. looks like it's due to incorrect git merge/rebase
i've filed #21428 with updated samples
Fix content for enum in addPartToMultiPartBuilder.
Enum is going forward set to MediaType
text/plainand not MediaTypeapplication/jsonin MultiPartBuilder and.toString()is used to get the value from the enum.