-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix MiskKotlin OpenApiGenerator types #21390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -64,7 +67,8 @@ class PetApiAction @Inject constructor( | |||
@LogRequestResponse(bodySampling = 1.0, errorBodySampling = 2.0) | |||
@Suppress("unused") | |||
fun findPetsByStatus( | |||
@QueryParam(value = "status") status: kotlin.Array<kotlin.String>): kotlin.Array<Pet> { | |||
@QueryParam(value = "status") status: kotlin.Array<kotlin.String> | |||
): kotlin.Array<Pet> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a lot of context of this file
But with the change above from Array
-> List
https://github.com/OpenAPITools/openapi-generator/pull/21390/files#diff-4c93f665fc6f95375f506f04f625f2cd823f4bf4907425b607124ba893812f73R1
Should this be kotlin.List<Pet>
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was late last night. Nice, fixed to kotlin.collections.List
@wing328 any chance we could get this into the |
Found a couple of bugs (so can we include this in the branch release)
@guiarn , @wing328
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@guiarn @wing328