Skip to content

Fix MiskKotlin OpenApiGenerator types #21390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025

Conversation

andrewwilsonnew
Copy link
Contributor

@andrewwilsonnew andrewwilsonnew commented Jun 5, 2025

Found a couple of bugs (so can we include this in the branch release)

  • void return from Action should be Response<Void>
  • Array type should be List in Misk

@guiarn , @wing328

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@guiarn @wing328

@andrewwilsonnew andrewwilsonnew marked this pull request as ready for review June 5, 2025 20:21
@@ -64,7 +67,8 @@ class PetApiAction @Inject constructor(
@LogRequestResponse(bodySampling = 1.0, errorBodySampling = 2.0)
@Suppress("unused")
fun findPetsByStatus(
@QueryParam(value = "status") status: kotlin.Array<kotlin.String>): kotlin.Array<Pet> {
@QueryParam(value = "status") status: kotlin.Array<kotlin.String>
): kotlin.Array<Pet> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of context of this file

But with the change above from Array -> List https://github.com/OpenAPITools/openapi-generator/pull/21390/files#diff-4c93f665fc6f95375f506f04f625f2cd823f4bf4907425b607124ba893812f73R1

Should this be kotlin.List<Pet> instead

Copy link
Contributor Author

@andrewwilsonnew andrewwilsonnew Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was late last night. Nice, fixed to kotlin.collections.List

@andrewwilsonnew andrewwilsonnew requested a review from sleiyer June 6, 2025 09:41
@andrewwilsonnew
Copy link
Contributor Author

@wing328 any chance we could get this into the 7.14.0 branch?

@wing328 wing328 merged commit 4402d83 into OpenAPITools:master Jun 6, 2025
36 checks passed
@wing328 wing328 added this to the 7.14.0 milestone Jun 6, 2025
@andrewwilsonnew andrewwilsonnew deleted the cashapp/misk7 branch June 10, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants