Skip to content

[rust-axum] Prevent multiple declarations of the same operation #21396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

rgroothuijsen
Copy link
Contributor

If tags are defined for an operation, the router path will be duplicated per tag. If a security schema is defined as well, the code will no longer compile because there will be duplicate operations with and without a claims parameter. Since there doesn't appear to be a benefit to specifying the same operation multiple times, this skips adding an operation if it already exists.

Fixes #21144

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jun 9, 2025

thanks for the pr

cc @linxGnu

Copy link
Contributor

@linxGnu linxGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM.

Could you please re-run integration test with following commands:

./bin/generate-samples.sh bin/configs/manual/rust-axum-*
mvn integration-test -f samples/server/petstore/rust-axum/pom.xml

@wing328
Copy link
Member

wing328 commented Jun 16, 2025

Could you please re-run integration test with following commands:

did these locally and the result is good

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.32s
[INFO]
[INFO] --- exec:1.2.1:exec (fmt) @ RustServerTests ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:43 min
[INFO] Finished at: 2025-06-16T10:34:01+08:00
[INFO] ------------------------------------------------------------------------
[INFO] 5 goals, 5 executed

@wing328 wing328 merged commit db38f0f into OpenAPITools:master Jun 16, 2025
14 checks passed
@wing328 wing328 added this to the 7.14.0 milestone Jun 19, 2025
@wing328
Copy link
Member

wing328 commented Jun 19, 2025

FYI. another way to address similar issue is to use the operationIdNameMappings option

ref: https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][rust-axum] Generated Server fails to supply correct number of Generic Arguments in routing
3 participants