Skip to content

[Java][vertx] fix path param encoding #21403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

[Java][vertx] fix path param encoding #21403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4247d8
Issue:21401 Fix Java vertx path param encoding
oscarobr Jun 10, 2025
da4a95c
Generate samples
oscarobr Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/Java/libraries/vertx/apiImpl.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public class {{classname}}Impl implements {{classname}} {

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion .../java/vertx-no-nullable/src/main/java/org/openapitools/client/api/AnotherFakeApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public void call123testSpecialTags(UUID uuidTest, Client body, ApiClient.AuthInf

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...etstore/java/vertx-no-nullable/src/main/java/org/openapitools/client/api/FakeApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ public void testQueryParameterCollectionFormat(List<String> pipe, List<String> i

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...tx-no-nullable/src/main/java/org/openapitools/client/api/FakeClassnameTags123ApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void testClassname(Client body, ApiClient.AuthInfo authInfo, Handler<Asyn

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...petstore/java/vertx-no-nullable/src/main/java/org/openapitools/client/api/PetApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ public void uploadFileWithRequiredFile(Long petId, AsyncFile requiredFile, Strin

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...tstore/java/vertx-no-nullable/src/main/java/org/openapitools/client/api/StoreApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ public void placeOrder(Order body, ApiClient.AuthInfo authInfo, Handler<AsyncRes

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...etstore/java/vertx-no-nullable/src/main/java/org/openapitools/client/api/UserApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ public void updateUser(String username, User body, ApiClient.AuthInfo authInfo,

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...ertx-supportVertxFuture/src/main/java/org/openapitools/client/api/AnotherFakeApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void call123testSpecialTags(Client client, ApiClient.AuthInfo authInfo, H

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...va/vertx-supportVertxFuture/src/main/java/org/openapitools/client/api/DefaultApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void fooGet(ApiClient.AuthInfo authInfo, Handler<AsyncResult<FooGetDefaul

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion .../java/vertx-supportVertxFuture/src/main/java/org/openapitools/client/api/FakeApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,7 @@ public void testStringMapReference(Map<String, String> requestBody, ApiClient.Au

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...ortVertxFuture/src/main/java/org/openapitools/client/api/FakeClassnameTags123ApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void testClassname(Client client, ApiClient.AuthInfo authInfo, Handler<As

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...e/java/vertx-supportVertxFuture/src/main/java/org/openapitools/client/api/PetApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ public void uploadFileWithRequiredFile(Long petId, AsyncFile requiredFile, Strin

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...java/vertx-supportVertxFuture/src/main/java/org/openapitools/client/api/StoreApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ public void placeOrder(Order order, ApiClient.AuthInfo authInfo, Handler<AsyncRe

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion .../java/vertx-supportVertxFuture/src/main/java/org/openapitools/client/api/UserApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ public void updateUser(String username, User user, ApiClient.AuthInfo authInfo,

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...ent/petstore/java/vertx/src/main/java/org/openapitools/client/api/AnotherFakeApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void call123testSpecialTags(Client client, ApiClient.AuthInfo authInfo, H

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion .../client/petstore/java/vertx/src/main/java/org/openapitools/client/api/DefaultApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void fooGet(ApiClient.AuthInfo authInfo, Handler<AsyncResult<FooGetDefaul

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...les/client/petstore/java/vertx/src/main/java/org/openapitools/client/api/FakeApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,7 @@ public void testStringMapReference(Map<String, String> requestBody, ApiClient.Au

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...ore/java/vertx/src/main/java/org/openapitools/client/api/FakeClassnameTags123ApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void testClassname(Client client, ApiClient.AuthInfo authInfo, Handler<As

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/java/vertx/src/main/java/org/openapitools/client/api/PetApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ public void uploadFileWithRequiredFile(Long petId, AsyncFile requiredFile, Strin

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...es/client/petstore/java/vertx/src/main/java/org/openapitools/client/api/StoreApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ public void placeOrder(Order order, ApiClient.AuthInfo authInfo, Handler<AsyncRe

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
2 changes: 1 addition & 1 deletion ...les/client/petstore/java/vertx/src/main/java/org/openapitools/client/api/UserApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ public void updateUser(String username, User user, ApiClient.AuthInfo authInfo,

private String encodeParameter(String parameter) {
try {
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name());
return URLEncoder.encode(parameter, StandardCharsets.UTF_8.name()).replaceAll("\\+", "%20");
} catch (UnsupportedEncodingException e) {
return parameter;
}
Expand Down
Loading