fix(python): skip license if not provided #21471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #21468, #21335
For a few years, the
pyproject.toml
license
field was set toNoLicense
when the spec did not provide another license. This value is not a valid SPDX identifier, however - as far as I can tell, there isn't any valid SPDX identifier for unlicensed code. (the Unlicense is NOT the same thing as UNLICENSED, ref).When this field was under the
[tool.poetry]
table, this was fine - Poetry doesn't seem to validate that field, or at least it allowsNoLicense
. Poetry docs onlicense
However, this field was moved under the
[project]
table in #21268. Bothpoetry
v2 anduv
(viasetuptools
) validate theproject.license
field, to ensure it's a valid SPDX identifier. BecauseNoLicense
is invalid, the build fails.Because there doesn't seem to be a valid identifier matching the spirit of NoLicense, I chose to remove the field entirely if a license is not provided.
note: some unrelated files had formatting changes when I ran
bin/generate-samples.sh
, included in the second commit.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)