Skip to content

fix(python): skip license if not provided #21471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

roryschadler
Copy link
Contributor

@roryschadler roryschadler commented Jun 26, 2025

Related: #21468, #21335

For a few years, the pyproject.toml license field was set to NoLicense when the spec did not provide another license. This value is not a valid SPDX identifier, however - as far as I can tell, there isn't any valid SPDX identifier for unlicensed code. (the Unlicense is NOT the same thing as UNLICENSED, ref).

When this field was under the [tool.poetry] table, this was fine - Poetry doesn't seem to validate that field, or at least it allows NoLicense. Poetry docs on license

However, this field was moved under the [project] table in #21268. Both poetry v2 and uv (via setuptools) validate the project.license field, to ensure it's a valid SPDX identifier. Because NoLicense is invalid, the build fails.

Because there doesn't seem to be a valid identifier matching the spirit of NoLicense, I chose to remove the field entirely if a license is not provided.

note: some unrelated files had formatting changes when I ran bin/generate-samples.sh, included in the second commit.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@roryschadler
Copy link
Contributor Author

@wing328
Copy link
Member

wing328 commented Jun 26, 2025

lgtm. thanks for the PR

(samples just updated in the master. thanks for also updating the samples in this PR)

@wing328 wing328 merged commit 6b5fd6e into OpenAPITools:master Jun 26, 2025
84 checks passed
@roryschadler roryschadler deleted the fix/roryschadler/skip-pyproject-license-if-none-provided branch June 26, 2025 16:50
@wing328 wing328 added this to the 7.15.0 milestone Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants